Skip to content

Symbol inconsistanties for I2C between ARM, AVR cores... #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WestfW opened this issue Mar 25, 2016 · 2 comments
Closed

Symbol inconsistanties for I2C between ARM, AVR cores... #4755

WestfW opened this issue Mar 25, 2016 · 2 comments

Comments

@WestfW
Copy link
Contributor

WestfW commented Mar 25, 2016

The AVR Arduino variants define symbols SCL and SDA for access to the Arduino Pin numbers associated with those functions:

static const uint8_t SDA = 18;
static const uint8_t SCL = 19;

The ARM Arduino variants (Due AND zero) define symbols PIN_WIRE_SDA and PIN_WIRE_SCL instead:

#define PIN_WIRE_SDA         (20u)
#define PIN_WIRE_SCL         (21u)

This makes it difficult to write libraries or sketches that will compile for both types of platforms.
Probably, both platforms should define both sets of symbols, but at least the AVR platforms should get the new-style (and better) PIN_xxx #defines.

(In fact, there are a lot of nice PIN_xxx defines that show up in the ARM platforms/variants that should probably be back-ported to the AVRs...)

@sandeepmistry
Copy link
Contributor

This can be closed once #4814, #4813, and arduino/ArduinoCore-samd#130 have been merged.

@WestfW let me know if I've missed anything.

@agdl
Copy link
Member

agdl commented Jul 7, 2016

I'm closing this thank you!

@agdl agdl closed this as completed Jul 7, 2016
@sandeepmistry sandeepmistry added this to the Release 1.6.10 milestone Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants