-
-
Notifications
You must be signed in to change notification settings - Fork 7k
request to add Rtc library #4485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
like for #4484 this library is without a tag |
You should also give it a less generic name by adding a prefix, like MakunaRtc. |
Do you mean change the class name and folder names to be MakunaRtc? Or just the name in the properties file? |
I mean the library name in properties file, because people may search for "Rtc" and find your library, thinking about a generic Rtc library, but confused afterwards by the fact that is a library specific for some models of RTC. |
Tag added. "v1.0" |
@Makuna please delete the tag v1.0 (a .x is missing) and rename the tag v1.0.0 into 1.0.0 (without the v) in order to be compliant with the other libraries |
You can't require all tags to be just used for your system. I could have the tag v1.0 for other purposes (other library managers) that you need to ignore/filter. How do you plan to support this? I could find no way in GitHub to remove releases or tags so I don't know how to even do it. I would suggest you also require the release title to be something like "arduino\arduino library release" so you could filter and ignore all others. I renamed it but it seems to have just created a new one. |
I added it. You should see it in the library manger in an hour. For what concern the tags actually you can write whatever you want but for compliance with all the other library I requested you to follow the "standard". What you actually see in the library manager is what is written in the library.properties associated to the tag that for the sake of simplicity is equal to the name of the tag with only numbers like in all the other libraries. I'm telling you this for what you asked in #4484 |
It is showing up with the wrong name. What are you seeing? I see MakunaRtc, but the properties files lists "Rtc by Makuna". |
I rebooted my computer the problem went away. Some sort of caching? The name I was seeing was what I changed it too before I submitted the fix. I switched to the name you see just before submitting. Even restarting the IDE didn't help. Oh well, problems gone. |
https://github.com/Makuna/Rtc
The text was updated successfully, but these errors were encountered: