Skip to content

request to add Rtc library #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Makuna opened this issue Jan 26, 2016 · 11 comments
Closed

request to add Rtc library #4485

Makuna opened this issue Jan 26, 2016 · 11 comments
Assignees
Labels
Component: Board/Lib Manager Boards Manager or Library Manager

Comments

@Makuna
Copy link

Makuna commented Jan 26, 2016

https://github.com/Makuna/Rtc

@facchinm facchinm added the Component: Board/Lib Manager Boards Manager or Library Manager label Jan 26, 2016
@agdl agdl self-assigned this Jan 26, 2016
@agdl
Copy link
Member

agdl commented Jan 26, 2016

like for #4484 this library is without a tag

@cmaglie
Copy link
Member

cmaglie commented Jan 26, 2016

You should also give it a less generic name by adding a prefix, like MakunaRtc.

@agdl agdl added the Waiting for feedback More information must be provided before we can proceed label Jan 26, 2016
@Makuna
Copy link
Author

Makuna commented Jan 26, 2016

Do you mean change the class name and folder names to be MakunaRtc? Or just the name in the properties file?

@cmaglie
Copy link
Member

cmaglie commented Jan 26, 2016

I mean the library name in properties file, because people may search for "Rtc" and find your library, thinking about a generic Rtc library, but confused afterwards by the fact that is a library specific for some models of RTC.

@Makuna
Copy link
Author

Makuna commented Jan 26, 2016

Tag added. "v1.0"
I updated the library title to "Rtc by Makuna".

@agdl
Copy link
Member

agdl commented Jan 27, 2016

@Makuna please delete the tag v1.0 (a .x is missing) and rename the tag v1.0.0 into 1.0.0 (without the v) in order to be compliant with the other libraries

@Makuna
Copy link
Author

Makuna commented Jan 27, 2016

You can't require all tags to be just used for your system. I could have the tag v1.0 for other purposes (other library managers) that you need to ignore/filter. How do you plan to support this?

I could find no way in GitHub to remove releases or tags so I don't know how to even do it.

I would suggest you also require the release title to be something like "arduino\arduino library release" so you could filter and ignore all others.

I renamed it but it seems to have just created a new one.

@agdl
Copy link
Member

agdl commented Jan 28, 2016

I added it. You should see it in the library manger in an hour.

For what concern the tags actually you can write whatever you want but for compliance with all the other library I requested you to follow the "standard". What you actually see in the library manager is what is written in the library.properties associated to the tag that for the sake of simplicity is equal to the name of the tag with only numbers like in all the other libraries. I'm telling you this for what you asked in #4484

@agdl agdl closed this as completed Jan 28, 2016
@Makuna
Copy link
Author

Makuna commented Jan 28, 2016

It is showing up with the wrong name. What are you seeing?

I see MakunaRtc, but the properties files lists "Rtc by Makuna".

@agdl
Copy link
Member

agdl commented Jan 29, 2016

screenshot from 2016-01-29 11 35 12

@Makuna
Copy link
Author

Makuna commented Jan 30, 2016

I rebooted my computer the problem went away. Some sort of caching? The name I was seeing was what I changed it too before I submitted the fix. I switched to the name you see just before submitting. Even restarting the IDE didn't help. Oh well, problems gone.

@cmaglie cmaglie removed the Waiting for feedback More information must be provided before we can proceed label Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Board/Lib Manager Boards Manager or Library Manager
Projects
None yet
Development

No branches or pull requests

4 participants