Skip to content

Advise users of duplicate libraries #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PaulStoffregen opened this issue Mar 30, 2015 · 3 comments
Closed

Advise users of duplicate libraries #2847

PaulStoffregen opened this issue Mar 30, 2015 · 3 comments

Comments

@PaulStoffregen
Copy link
Contributor

Sometimes Arduino users will install a duplicate copy of a library, or another library that appears to be a duplicate due to conflicting header file names. Sometimes this actually works, but breaks months or years later when other code depending on those libraries updates, long after the user as forgotten they installed the library.

When this problem strikes, the user gets incomprehensible compiler errors.

Arduino should detect duplicate or ambiguous library matches and print a friendly warning after compiling, even if no error resulted, to give users clear visibility that it had to guess which library to build into their program.

@PaulStoffregen
Copy link
Contributor Author

@ffissore - I'm working on a patch with the new 1.6.2 code. I have the duplicate detection part working pretty well.

The difficult part is the new LibrariesIndexer class. As it rescans libraries, it uses LibraryList addOrReplace(lib). That produces a nice list, but a lot of information about possible duplicates is lost. I have the rest working, and now I'm trying to extend LibraryList to also create a list with duplicates preserved. Does that sound ok? Or would you prefer this done some other way?

@ffissore
Copy link
Contributor

Sounds ok to me

@ffissore
Copy link
Contributor

ffissore commented Apr 1, 2015

#2850 merged, closing

@ffissore ffissore closed this as completed Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants