Skip to content

Duplicate IRremote #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpflaga opened this issue Mar 4, 2014 · 4 comments
Closed

Duplicate IRremote #1909

mpflaga opened this issue Mar 4, 2014 · 4 comments
Labels
Board: Arduino Robot Applies only to the Arduino Robot Component: IDE The Arduino IDE Component: Toolchain The tools used for compilation and uploading to Arduino boards

Comments

@mpflaga
Copy link

mpflaga commented Mar 4, 2014

The way in which \libraries\RobotIRremote\src\IRremote was added, causes this library to take precedence, in conflict with those who have been using the alternate forks in their .\Arduino\libraries\IRremote. folders.

This locking in of this library seams contrary to the goals of allowing customizable libraries. I understand the goal of using it within the Robot Project to ensure support, but this inadvertently over rides all of the other forks of IRremote.

For example I see the SD library is an older instance of SdFatLib, but was implemented in the stock library with a unique Name and such, as not to conflict with more current and or other forks of SdFatLib.

Is there a way to politely select the users libraries as the preferred when present, other than deleting the src directory (not altering the IDE's stock environment). Or should some additional effort be used to ensure functional co-existence. As not to jack the library and others ability to use their prior versions of the library on stock IDE.

There will be a lot of newbies who won't understand why this long lasting proven library stopped working.

@tdicola
Copy link

tdicola commented Jun 12, 2014

I'm hitting this issue too and wondering is there any workaround other than forking the original IR remote library and changing the name of the headers? The annoying thing is that the robot IR library doesn't support all the extremely useful functionality of the original IR library, i.e. many of the IR send routines are commented out.

I'd like to publish a project that uses the Yun and original IR remote library but this issue will really throw people for a loop. As a workaround I'll fork the original library and change the source names, but it would be nice to have some definitive fix or convention for dealing with user vs. internal libraries.

@NicoHood
Copy link
Contributor

NicoHood commented Aug 7, 2014

The problem is still in IDE 1.5.7
Why do you copy the library if you dont use it?

Also i suggest you to have a look at this IR library which is way faster and can detect way better the signals and has less memory usage: https://github.com/NicoHood/IRLremote
I could possibly make it work with PCINT but then SoftSerial would be impossible i think.

@matthijskooijman
Copy link
Collaborator

Why do you copy the library if you dont use it?
Are you saying the robot library that includes irremote doesn't actually use it?

In any case, AFAIU the IRRemote library was included so that it gets automatically compiled when using the robot library, without having to manually reference it from the .ino file. It's a bit of a hack, which should be unneeded once #2174 is merged. With that PR merged, the IRRemote library could be included as a complete library with the IDE and then a version of the library in the user's sketchbook should (AFAIK) override the shipped version.

@ffissore
Copy link
Contributor

This has been fixed by #2681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: Arduino Robot Applies only to the Arduino Robot Component: IDE The Arduino IDE Component: Toolchain The tools used for compilation and uploading to Arduino boards
Projects
None yet
Development

No branches or pull requests

6 participants