Skip to content

Commit 61c5176

Browse files
committed
only print Leonardo upload port hunting status if verbose uploading is selected. also cleaned up other verbose message handling for Leonardo upload progress.
1 parent 97d9ce9 commit 61c5176

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

app/src/processing/app/debug/AvrdudeUploader.java

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ private boolean uploadViaBootloader(String buildPath, String className)
9191
// Toggle 1200 bps on selected serial port to force board reset.
9292
List<String> before = Serial.list();
9393
if (before.contains(uploadPort)) {
94-
if (verbose)
94+
if (verbose || Preferences.getBoolean("upload.verbose"))
9595
System.out
9696
.println(_("Forcing reset using 1200bps open/close on port ")
9797
+ uploadPort);
@@ -110,19 +110,22 @@ private boolean uploadViaBootloader(String buildPath, String className)
110110
List<String> now = Serial.list();
111111
List<String> diff = new ArrayList<String>(now);
112112
diff.removeAll(before);
113-
System.out.print("{");
114-
for (String p : before)
115-
System.out.print(p+",");
116-
System.out.print("} / {");
117-
for (String p : now)
118-
System.out.print(p+",");
119-
System.out.print("} => {");
120-
for (String p : diff)
121-
System.out.print(p+",");
122-
System.out.println("}");
113+
if (verbose || Preferences.getBoolean("upload.verbose")) {
114+
System.out.print("PORTS {");
115+
for (String p : before)
116+
System.out.print(p+", ");
117+
System.out.print("} / {");
118+
for (String p : now)
119+
System.out.print(p+", ");
120+
System.out.print("} => {");
121+
for (String p : diff)
122+
System.out.print(p+", ");
123+
System.out.println("}");
124+
}
123125
if (diff.size() > 0) {
124126
caterinaUploadPort = diff.get(0);
125-
System.out.println("found leo: " + caterinaUploadPort);
127+
if (verbose || Preferences.getBoolean("upload.verbose"))
128+
System.out.println("Found Leonardo upload port: " + caterinaUploadPort);
126129
break;
127130
}
128131

@@ -135,7 +138,8 @@ private boolean uploadViaBootloader(String buildPath, String className)
135138
// come back, so use a longer time out before assuming that the selected
136139
// port is the bootloader (not the sketch).
137140
if (((!Base.isWindows() && elapsed >= 500) || elapsed >= 5000) && now.contains(uploadPort)) {
138-
System.out.println("using selected port: " + uploadPort);
141+
if (verbose || Preferences.getBoolean("upload.verbose"))
142+
System.out.println("Uploading using selected port: " + uploadPort);
139143
caterinaUploadPort = uploadPort;
140144
break;
141145
}
@@ -144,7 +148,7 @@ private boolean uploadViaBootloader(String buildPath, String className)
144148
if (caterinaUploadPort == null)
145149
// Something happened while detecting port
146150
throw new RunnerException(
147-
_("Couldn’t find the selected board. Try pressing the reset button after initiating the upload."));
151+
_("Couldn’t find a Leonardo on the selected port. Check that you have the correct port selected. If it is correct, try pressing the board's reset button after initiating the upload."));
148152

149153
uploadPort = caterinaUploadPort;
150154
} catch (SerialException e) {

0 commit comments

Comments
 (0)