Add getTabs() and getCurrentTabIndex() to Editor and use them

Previously, some of the GUI code would use Editor.getSketch() to get the
current sketch, and Sketch.getCurrentCode() to find out the currently
selected tab. Since this code is really concerned with the currently
open tab in the GUI, it makes more sense to query the Editor tabs list
directly.

This removes all references the current sketch code, as tracked by
Sketch, external to Sketch itself. This prepares for removing the
current tab tracking from Sketch later.

Author: matthijskooijman

Diff for: app/src/cc/arduino/view/findreplace/FindReplace.java

@@ -327,18 +327,19 @@ private boolean find(boolean wrap, boolean backwards, boolean searchTabs, int or
     if (nextIndex == -1) {
       // Nothing found on this tab: Search other tabs if required
       if (searchTabs) {
-        // editor.
+        int numTabs = editor.getTabs().size();
         Sketch sketch = editor.getSketch();
-        if (sketch.getCodeCount() > 1) {
-          int realCurrentTab = sketch.getCodeIndex(sketch.getCurrentCode());
+        if (numTabs > 1) {
+          int realCurrentTab = editor.getCurrentTabIndex();
 
           if (originTab != realCurrentTab) {
             if (originTab < 0) {
               originTab = realCurrentTab;
             }
 
             if (!wrap) {
-              if ((!backwards && realCurrentTab + 1 >= sketch.getCodeCount()) || (backwards && realCurrentTab - 1 < 0)) {
+              if ((!backwards && realCurrentTab + 1 >= numTabs)
+                  || (backwards && realCurrentTab - 1 < 0)) {
                 return false; // Can't continue without wrap
               }
             }

Diff for: app/src/processing/app/Editor.java

@@ -1583,6 +1583,21 @@ public Sketch getSketch() {
   public EditorTab getCurrentTab() {
     return tabs.get(currentTabIndex);
   }
+
+  /**
+   * Gets the index of the currently displaying tab.
+   */
+  public int getCurrentTabIndex() {
+    return currentTabIndex;
+  }
+
+  /**
+   * Returns an (unmodifiable) list of currently opened tabs.
+   */
+  public List<EditorTab> getTabs() {
+    return Collections.unmodifiableList(tabs);
+  }
+
   // . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
   /**
    * Change the currently displayed tab.
@@ -1970,10 +1985,12 @@ private void updateTitle() {
     if (sketch == null) {
       return;
     }
-    if (sketch.getName().equals(sketch.getCurrentCode().getPrettyName())) {
+    SketchCode current = getCurrentTab().getSketchCode();
+    if (sketch.getName().equals(current.getPrettyName())) {
       setTitle(I18n.format(tr("{0} | Arduino {1}"), sketch.getName(), BaseNoGui.VERSION_NAME_LONG));
     } else {
-      setTitle(I18n.format(tr("{0} - {1} | Arduino {2}"), sketch.getName(), sketch.getCurrentCode().getFileName(), BaseNoGui.VERSION_NAME_LONG));
+      setTitle(I18n.format(tr("{0} - {1} | Arduino {2}"), sketch.getName(),
+                           current.getFileName(), BaseNoGui.VERSION_NAME_LONG));
     }
   }
 
@@ -2526,7 +2543,7 @@ private void handlePrint() {
       printerJob.setPrintable(getCurrentTab().getTextArea());
     }
     // set the name of the job to the code name
-    printerJob.setJobName(sketch.getCurrentCode().getPrettyName());
+    printerJob.setJobName(getCurrentTab().getSketchCode().getPrettyName());
 
     if (printerJob.printDialog()) {
       try {

Diff for: app/src/processing/app/EditorHeader.java

@@ -32,7 +32,7 @@
 import java.awt.*;
 import java.awt.event.*;
 import java.io.IOException;
-
+import java.util.List;
 import javax.swing.*;
 
 
@@ -229,15 +229,18 @@ public void paintComponent(Graphics screen) {
     g.setColor(backgroundColor);
     g.fillRect(0, 0, imageW, imageH);
 
-    int codeCount = sketch.getCodeCount();
+    List<EditorTab> tabs = editor.getTabs();
+
+    int codeCount = tabs.size();
     if ((tabLeft == null) || (tabLeft.length < codeCount)) {
       tabLeft = new int[codeCount];
       tabRight = new int[codeCount];
     }
 
     int x = 6; // offset from left edge of the component
-    for (int i = 0; i < sketch.getCodeCount(); i++) {
-      SketchCode code = sketch.getCode(i);
+    int i = 0;
+    for (EditorTab tab : tabs) {
+      SketchCode code = tab.getSketchCode();
 
       String codeName = code.isExtension(sketch.getHiddenExtensions()) ?
         code.getPrettyName() : code.getFileName();
@@ -252,7 +255,7 @@ public void paintComponent(Graphics screen) {
       int pieceCount = 2 + (textWidth / PIECE_WIDTH);
       int pieceWidth = pieceCount * PIECE_WIDTH;
 
-      int state = (code == sketch.getCurrentCode()) ? SELECTED : UNSELECTED;
+      int state = (i == editor.getCurrentTabIndex()) ? SELECTED : UNSELECTED;
       g.drawImage(pieces[state][LEFT], x, 0, null);
       x += PIECE_WIDTH;
 
@@ -272,6 +275,7 @@ public void paintComponent(Graphics screen) {
 
       g.drawImage(pieces[state][RIGHT], x, 0, null);
       x += PIECE_WIDTH - 1;  // overlap by 1 pixel
+      i++;
     }
 
     menuLeft = sizeW - (16 + pieces[0][MENU].getWidth(this));
@@ -318,7 +322,8 @@ public void rebuildMenu() {
     if (sketch != null) {
       menu.addSeparator();
       int i = 0;
-      for (SketchCode code : sketch.getCodes()) {
+      for (EditorTab tab : editor.getTabs()) {
+        SketchCode code = tab.getSketchCode();
         final int index = i++;
         item = new JMenuItem(code.isExtension(sketch.getDefaultExtension()) ? 
                              code.getPrettyName() : code.getFileName());