Fix portable mode and make the fileCached immutable

Author: Mattia Bertorello

arduino-core/src/cc/arduino/contributions/DownloadableContributionsDownloader.java

@@ -170,6 +170,7 @@ public void downloadIndexAndSignature(MultiStepProgress progress, URL packageInd
         log.info("The domain is not selected to verify the signature. will be copied into this path {}, packageIndex url: {}", packageIndex, packageIndexUrl);
       }
     } catch (Exception e) {
+      log.error("Cannot download the package index from {} the package will be discard", packageIndexUrl, e);
       throw e;
     } finally {
       // Delete useless temp file

arduino-core/src/cc/arduino/contributions/libraries/LibraryInstaller.java

@@ -48,8 +48,6 @@
 import java.net.URL;
 import java.nio.file.Files;
 import java.nio.file.StandardCopyOption;
-import java.util.LinkedList;
-import java.util.List;
 import java.util.Optional;
 
 import static processing.app.I18n.tr;

arduino-core/src/cc/arduino/utils/network/FileDownloader.java

@@ -147,7 +147,7 @@ private void downloadFile(boolean noResume) throws InterruptedException {
 
       final Optional<FileDownloaderCache.FileCached> fileCached = FileDownloaderCache.getFileCached(downloadUrl);
 
-      if (fileCached.isPresent() && !fileCached.get().isChange()) {
+      if (fileCached.isPresent() && fileCached.get().isNotChange()) {
         try {
           final Optional<File> fileFromCache =
             fileCached.get().getFileFromCache();
@@ -156,11 +156,17 @@ private void downloadFile(boolean noResume) throws InterruptedException {
             FileUtils.copyFile(fileFromCache.get(), outputFile);
             setStatus(Status.COMPLETE);
             return;
+          } else {
+            log.info(
+              "The file in the cache is not in the path or the md5 validation failed: path={}, file exist={}, md5 validation={}",
+              fileCached.get().getLocalPath(), fileCached.get().exists(), fileCached.get().md5Check());
           }
         } catch (Exception e) {
           log.warn(
-            "Cannot get the file from the cache, will be downloaded a new one ", e.getCause());
+            "Cannot get the file from the cache, will be downloaded a new one ", e);
         }
+      } else {
+        log.info("The file is change {}", fileCached);
       }
 
       initialSize = outputFile.length();
@@ -226,10 +232,12 @@ private void downloadFile(boolean noResume) throws InterruptedException {
     } catch (SocketTimeoutException e) {
       setStatus(Status.CONNECTION_TIMEOUT_ERROR);
       setError(e);
+      log.error(e);
 
     } catch (Exception e) {
       setStatus(Status.ERROR);
       setError(e);
+      log.error(e);
 
     } finally {
       IOUtils.closeQuietly(randomAccessOutputFile);