Refactor http successfull request logs in one line

Author: Roberto Sora

Diff for: arduino-core/src/cc/arduino/utils/network/HttpConnectionManager.java

@@ -17,51 +17,52 @@
 import java.util.function.Consumer;
 
 public class HttpConnectionManager {
-  private static Logger log = LoggerFactory.getLogger(HttpConnectionManager.class);
+  private static Logger log = LoggerFactory
+    .getLogger(HttpConnectionManager.class);
   private final URL requestURL;
   private final String userAgent;
   private int connectTimeout;
 
-
   public HttpConnectionManager(URL requestURL) {
     this.requestURL = requestURL;
-    final String defaultUserAgent = String.format(
-      "ArduinoIDE/%s (%s; %s; %s; %s) Java/%s (%s)",
-      BaseNoGui.VERSION_NAME,
-      System.getProperty("os.name"),
-      System.getProperty("os.version"),
-      System.getProperty("os.arch"),
-      System.getProperty("user.language"),
-      System.getProperty("java.version"),
-      System.getProperty("java.vendor")
-    );
+    final String defaultUserAgent = String
+      .format("ArduinoIDE/%s (%s; %s; %s; %s) Java/%s (%s)",
+              BaseNoGui.VERSION_NAME, System.getProperty("os.name"),
+              System.getProperty("os.version"), System.getProperty("os.arch"),
+              System.getProperty("user.language"),
+              System.getProperty("java.version"),
+              System.getProperty("java.vendor"));
     this.userAgent = PreferencesData.get("http.user_agent", defaultUserAgent);
     try {
-      this.connectTimeout =
-        Integer.parseInt(
-          PreferencesData.get("http.connection_timeout", "5000"));
+      this.connectTimeout = Integer
+        .parseInt(PreferencesData.get("http.connection_timeout", "5000"));
     } catch (NumberFormatException e) {
       log.warn(
-        "Cannot parse the http.connection_timeout configuration switch to default 5000 milliseconds", e.getCause());
+        "Cannot parse the http.connection_timeout configuration switch to default 5000 milliseconds",
+        e.getCause());
       this.connectTimeout = 5000;
     }
 
   }
 
-  public HttpURLConnection makeConnection(Consumer<HttpURLConnection> beforeConnection)
-    throws IOException, NoSuchMethodException, ScriptException, URISyntaxException {
+  public HttpURLConnection makeConnection(
+    Consumer<HttpURLConnection> beforeConnection)
+    throws IOException, NoSuchMethodException, ScriptException,
+    URISyntaxException {
     return makeConnection(this.requestURL, 0, beforeConnection);
   }
 
-
   public HttpURLConnection makeConnection()
-    throws IOException, NoSuchMethodException, ScriptException, URISyntaxException {
-    return makeConnection(this.requestURL, 0, (c) -> {});
+    throws IOException, NoSuchMethodException, ScriptException,
+    URISyntaxException {
+    return makeConnection(this.requestURL, 0, (c) -> {
+    });
   }
 
   private HttpURLConnection makeConnection(URL requestURL, int movedTimes,
-                                           Consumer<HttpURLConnection> beforeConnection) throws IOException, URISyntaxException, ScriptException, NoSuchMethodException {
-    log.info("Prepare http request to " + requestURL);
+                                           Consumer<HttpURLConnection> beforeConnection)
+    throws IOException, URISyntaxException, ScriptException,
+    NoSuchMethodException {
     if (movedTimes > 3) {
       log.warn("Too many redirect " + requestURL);
       throw new IOException("Too many redirect " + requestURL);
@@ -85,21 +86,21 @@ private HttpURLConnection makeConnection(URL requestURL, int movedTimes,
     connection.setConnectTimeout(connectTimeout);
     beforeConnection.accept(connection);
 
-    // Connect
-    log.info("Connect to {} with method {}", requestURL, connection.getRequestMethod());
-
     connection.connect();
     int resp = connection.getResponseCode();
 
     if (resp == HttpURLConnection.HTTP_MOVED_PERM
         || resp == HttpURLConnection.HTTP_MOVED_TEMP) {
 
       URL newUrl = new URL(connection.getHeaderField("Location"));
-      log.info("The response code was a 301,302 so try again with the new URL " + newUrl);
+      log.info("The response code was a 301,302 so try again with the new URL "
+               + newUrl);
 
       return this.makeConnection(newUrl, movedTimes + 1, beforeConnection);
     }
-    log.info("The response code {}, headers {}", resp, StringUtils.join(connection.getHeaderFields()));
+    log.info("Executed {} successfully to {} code {}, headers {}",
+             connection.getRequestMethod(), requestURL, resp,
+             StringUtils.join(connection.getHeaderFields()));
 
     return connection;
   }