Fixed NPE when unknown platform/board are selected in preference

Author: cmaglie

app/src/processing/app/Base.java

@@ -970,6 +970,8 @@ protected void rebuildSketchbookMenu(JMenu menu) {
   }
 
   public Map<String, File> getIDELibs() {
+    if (libraries == null)
+      return new HashMap<String, File>();
     Map<String, File> ideLibs = new HashMap<String, File>(libraries);
     for (String lib : libraries.keySet()) {
       if (FileUtils.isSubDirectory(getSketchbookFolder(), libraries.get(lib)))
@@ -979,6 +981,8 @@ public Map<String, File> getIDELibs() {
   }
 
   public Map<String, File> getUserLibs() {
+    if (libraries == null)
+      return new HashMap<String, File>();
     Map<String, File> userLibs = new HashMap<String, File>(libraries);
     for (String lib : libraries.keySet()) {
       if (!FileUtils.isSubDirectory(getSketchbookFolder(), libraries.get(lib)))
@@ -1002,34 +1006,37 @@ public void actionPerformed(ActionEvent e) {
     importMenu.add(addLibraryMenuItem);
 
     // Split between user supplied libraries and IDE libraries
-    Map<String, File> ideLibs = getIDELibs();
-    Map<String, File> userLibs = getUserLibs();
-    try {
-      // Find the current target. Get the platform, and then select the
-      // correct name and core path.
-      PreferencesMap prefs = getTargetPlatform().getPreferences();
-      String targetname = prefs.get("name");
-
-      if (false) {
-	// Hack to extract these words by gettext tool.
-	// These phrases are actually defined in the "platform.txt".
-	String notused = _("Arduino AVR Boards");
-	notused = _("Arduino ARM (32-bits) Boards");
-      }
+    TargetPlatform targetPlatform = getTargetPlatform();
+    if (targetPlatform != null) {
+      Map<String, File> ideLibs = getIDELibs();
+      Map<String, File> userLibs = getUserLibs();
+      try {
+        // Find the current target. Get the platform, and then select the
+        // correct name and core path.
+        PreferencesMap prefs = targetPlatform.getPreferences();
+        String targetname = prefs.get("name");
+
+        if (false) {
+          // Hack to extract these words by gettext tool.
+          // These phrases are actually defined in the "platform.txt".
+          String notused = _("Arduino AVR Boards");
+          notused = _("Arduino ARM (32-bits) Boards");
+        }
 
-      JMenuItem platformItem = new JMenuItem(_(targetname));
-      platformItem.setEnabled(false);
-      importMenu.add(platformItem);
-      if (ideLibs.size()>0) {
-        importMenu.addSeparator();
-        addLibraries(importMenu, ideLibs);
-      }
-      if (userLibs.size()>0) {
-        importMenu.addSeparator();
-        addLibraries(importMenu, userLibs);
+        JMenuItem platformItem = new JMenuItem(_(targetname));
+        platformItem.setEnabled(false);
+        importMenu.add(platformItem);
+        if (ideLibs.size() > 0) {
+          importMenu.addSeparator();
+          addLibraries(importMenu, ideLibs);
+        }
+        if (userLibs.size() > 0) {
+          importMenu.addSeparator();
+          addLibraries(importMenu, userLibs);
+        }
+      } catch (IOException e) {
+        e.printStackTrace();
       }
-    } catch (IOException e) {
-      e.printStackTrace();
     }
   }
 
@@ -1132,11 +1139,15 @@ public File scanFatLibrary(File libFolder) {
   }
 
   public void onBoardOrPortChange() {
+    TargetPlatform targetPlatform = getTargetPlatform();
+    if (targetPlatform == null)
+      return;
+    
     // Calculate paths for libraries and examples
     examplesFolder = getContentFile("examples");
     toolsFolder = getContentFile("tools");
 
-    File platformFolder = getTargetPlatform().getFolder();
+    File platformFolder = targetPlatform.getFolder();
     librariesFolders = new ArrayList<File>();
     librariesFolders.add(getContentFile("libraries"));
     librariesFolders.add(new File(platformFolder, "libraries"));
@@ -1400,6 +1411,9 @@ public void actionPerformed(ActionEvent actionevent) {
    */
   protected boolean addSketches(JMenu menu, File folder,
                                 final boolean replaceExisting) throws IOException {
+    if (folder == null)
+      return false;
+    
     // skip .DS_Store files, etc (this shouldn't actually be necessary)
     if (!folder.isDirectory()) return false;
 
@@ -1846,7 +1860,10 @@ static public TargetPlatform getTargetPlatform() {
    */
   static public TargetPlatform getTargetPlatform(String packageName,
                                                  String platformName) {
-    return packages.get(packageName).get(platformName);
+    TargetPackage p = packages.get(packageName);
+    if (p == null)
+      return null;
+    return p.get(platformName);
   }
 
   static public TargetPlatform getCurrentTargetPlatformFromPackage(String pack) {

app/src/processing/app/Editor.java

@@ -727,7 +727,10 @@ public void menuSelected(MenuEvent e) {
 
 
   protected void addTools(JMenu menu, File sourceFolder) {
-    HashMap<String, JMenuItem> toolItems = new HashMap<String, JMenuItem>();
+    if (sourceFolder == null)
+      return;
+    
+    Map<String, JMenuItem> toolItems = new HashMap<String, JMenuItem>();
 
     File[] folders = sourceFolder.listFiles(new FileFilter() {
       public boolean accept(File folder) {