Skip to content

Set scope of enum values to enum class #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set scope of enum values to enum class #53

wants to merge 1 commit into from

Conversation

sebromero
Copy link
Contributor

Fixes #52. It does so by confining the scope of the enum values to the enum class. This would only break compatibility for boards using old toolchains, namely AVR boards which are not supported by this library anyway. I can't think of any side effects.

@sebromero sebromero mentioned this pull request Apr 16, 2025
Open
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name collision with ArduinoIoTCloud library
2 participants
@sebromero @per1234