Skip to content

Move source code into src subfolder. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aentinger opened this issue Oct 1, 2020 · 2 comments · Fixed by #10
Closed

Move source code into src subfolder. #9

aentinger opened this issue Oct 1, 2020 · 2 comments · Fixed by #10

Comments

@aentinger
Copy link
Contributor

Hi @facchinm 👋

I've been wondering if there's a need (caused by your builder modifications) for all the source files to be located in the top-level library folder or if they can be safely moved into src subfolder?

@facchinm
Copy link
Collaborator

facchinm commented Oct 1, 2020

There should be no issue (we need to double check this line https://github.com/bcmi-labs/Arduino_Threads/blob/master/Wire.h#L4 ).
Do you mind testing it with the examples and eventually file a PR now that there's nothing open 😉 ?

@aentinger
Copy link
Contributor Author

I've created the PR ( #10 ) but my builder is currently broken. I was hoping you could test it 👼 (a compile should be fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants