Skip to content

Commit a9330ec

Browse files
committed
Reorder WireBusDevice create functions to form a natural progression from few parameters to many.
1 parent 062bb0a commit a9330ec

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/BusDeviceCreator.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,19 @@ SpiBusDevice BusDeviceCreator::create(arduino::SPIClass & spi, SPISettings const
4343
return SpiBusDevice(SpiBusDeviceConfig{spi, spi_settings, cs_pin, fill_symbol});
4444
}
4545

46-
WireBusDevice BusDeviceCreator::create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart, bool const stop)
46+
WireBusDevice BusDeviceCreator::create(arduino::HardwareI2C & wire, byte const slave_addr)
4747
{
48-
return WireBusDevice(WireBusDeviceConfig{wire, slave_addr, restart, stop});
48+
return create(wire, slave_addr, true, true);
4949
}
5050

5151
WireBusDevice BusDeviceCreator::create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart)
5252
{
5353
return create(wire, slave_addr, restart, true);
5454
}
5555

56-
WireBusDevice BusDeviceCreator::create(arduino::HardwareI2C & wire, byte const slave_addr)
56+
WireBusDevice BusDeviceCreator::create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart, bool const stop)
5757
{
58-
return create(wire, slave_addr, true, true);
58+
return WireBusDevice(WireBusDeviceConfig{wire, slave_addr, restart, stop});
5959
}
6060

6161
/**************************************************************************************

src/BusDeviceCreator.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ class BusDeviceCreator
4040
SpiBusDevice create(arduino::SPIClass & spi, SPISettings const & spi_settings, SpiBusDeviceConfig::SpiSelectFunc spi_select, SpiBusDeviceConfig::SpiDeselectFunc spi_deselect, byte const fill_symbol = 0xFF);
4141
SpiBusDevice create(arduino::SPIClass & spi, SPISettings const & spi_settings, int const cs_pin, byte const fill_symbol = 0xFF);
4242

43-
WireBusDevice create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart, bool const stop);
44-
WireBusDevice create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart);
4543
WireBusDevice create(arduino::HardwareI2C & wire, byte const slave_addr);
44+
WireBusDevice create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart);
45+
WireBusDevice create(arduino::HardwareI2C & wire, byte const slave_addr, bool const restart, bool const stop);
4646

4747
};
4848

0 commit comments

Comments
 (0)