begin(baudrate,config) needs to be locked against multi-threaded access from the very start.! (#14)

aentinger · web-flow · commit a04ae1fffe2c · 2021-09-03T10:10:01.000+02:00
diff --git a/src/serial/SerialDispatcher.cpp b/src/serial/SerialDispatcher.cpp
@@ -49,6 +49,8 @@ void SerialDispatcher::begin(unsigned long baudrate)
 
 void SerialDispatcher::begin(unsigned long baudrate, uint16_t config)
 {
+  mbed::ScopedLock<rtos::Mutex> lock(_mutex);
+
   if (!_is_initialized)
   {
     _serial.begin(baudrate, config);
@@ -57,8 +59,6 @@ void SerialDispatcher::begin(unsigned long baudrate, uint16_t config)
     while (!_has_tread_started) { }
   }
 
-  mbed::ScopedLock<rtos::Mutex> lock(_mutex);
-
   /* Check if the thread calling begin is already in the list. */
   osThreadId_t const current_thread_id = rtos::ThisThread::get_id();
   if (findThreadCustomerDataById(rtos::ThisThread::get_id()) == std::end(_thread_customer_list))

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,8 @@ void SerialDispatcher::begin(unsigned long baudrate)`
`49`	`49`
`50`	`50`	`void SerialDispatcher::begin(unsigned long baudrate, uint16_t config)`
`51`	`51`	`{`
	`52`	`+ mbed::ScopedLock<rtos::Mutex> lock(_mutex);`
	`53`	`+`
`52`	`54`	`if (!_is_initialized)`
`53`	`55`	`{`
`54`	`56`	`_serial.begin(baudrate, config);`
`@@ -57,8 +59,6 @@ void SerialDispatcher::begin(unsigned long baudrate, uint16_t config)`
`57`	`59`	`while (!_has_tread_started) { }`
`58`	`60`	`}`
`59`	`61`
`60`		`- mbed::ScopedLock<rtos::Mutex> lock(_mutex);`
`61`		`-`
`62`	`62`	`/* Check if the thread calling begin is already in the list. */`
`63`	`63`	`osThreadId_t const current_thread_id = rtos::ThisThread::get_id();`
`64`	`64`	`if (findThreadCustomerDataById(rtos::ThisThread::get_id()) == std::end(_thread_customer_list))`