Rename set/get to push/pop to better reflect on the fact that its not a simple variable but a queue.

Author: aentinger

src/threading/Shared.hpp

@@ -40,8 +40,8 @@ class Shared
 {
 public:
 
-  T get();
-  void set(T const & val);
+  T pop();
+  void push(T const & val);
 
   operator T();
   void operator = (T const & val);
@@ -60,7 +60,7 @@ class Shared
  **************************************************************************************/
 
 template<class T, size_t QUEUE_SIZE>
-T Shared<T,QUEUE_SIZE>::get()
+T Shared<T,QUEUE_SIZE>::pop()
 {
   T * val_ptr = _mailbox.try_get_for(rtos::Kernel::wait_for_u32_forever);
   if (val_ptr)
@@ -73,7 +73,7 @@ T Shared<T,QUEUE_SIZE>::get()
 }
 
 template<class T, size_t QUEUE_SIZE>
-void Shared<T,QUEUE_SIZE>::set(T const & val)
+void Shared<T,QUEUE_SIZE>::push(T const & val)
 {
   /* If the mailbox is full we are discarding the
    * oldest element and then push the new one into
@@ -98,13 +98,13 @@ void Shared<T,QUEUE_SIZE>::set(T const & val)
 template<class T, size_t QUEUE_SIZE>
 Shared<T,QUEUE_SIZE>::operator T()
 {
-  return get();
+  return pop();
 }
 
 template<class T, size_t QUEUE_SIZE>
 void Shared<T,QUEUE_SIZE>::operator = (T const & val)
 {
-  set(val);
+  push(val);
 }
 
 #endif /* ARDUINO_THREADS_SHARED_HPP_ */

src/threading/Sink.hpp

@@ -38,10 +38,10 @@ class SinkBase
 
   virtual ~SinkBase() { }
 
-  virtual T get() = 0;
+  virtual T pop() = 0;
   virtual void inject(T const & value) = 0;
 
-  inline operator T() { return get(); }
+  inline operator T() { return pop(); }
 };
 
 template<typename T>
@@ -52,7 +52,7 @@ class SinkNonBlocking : public SinkBase<T>
            SinkNonBlocking() { }
   virtual ~SinkNonBlocking() { }
 
-  virtual T get() override;
+  virtual T pop() override;
   virtual void inject(T const & value) override;
 
 
@@ -71,7 +71,7 @@ class SinkBlocking : public SinkBase<T>
            SinkBlocking(size_t const size);
   virtual ~SinkBlocking() { }
 
-  virtual T get() override;
+  virtual T pop() override;
   virtual void inject(T const & value) override;
 
 
@@ -89,7 +89,7 @@ class SinkBlocking : public SinkBase<T>
  **************************************************************************************/
 
 template<typename T>
-T SinkNonBlocking<T>::get()
+T SinkNonBlocking<T>::pop()
 {
   _mutex.lock();
   return _data;
@@ -116,7 +116,7 @@ SinkBlocking<T>::SinkBlocking(size_t const size)
 { }
 
 template<typename T>
-T SinkBlocking<T>::get()
+T SinkBlocking<T>::pop()
 {
   _mutex.lock();
   while (_data.isEmpty())

src/threading/Source.hpp

@@ -43,7 +43,7 @@ class Source
 public:
 
   void connectTo(SinkBase<T> & sink);
-  void set(T const & val);
+  void push(T const & val);
   void operator = (T const & val);
 
 private:
@@ -61,7 +61,7 @@ void Source<T>::connectTo(SinkBase<T> & sink)
 }
 
 template<typename T>
-void Source<T>::set(T const & val)
+void Source<T>::push(T const & val)
 {
   std::for_each(std::begin(_sink_list),
                 std::end  (_sink_list),
@@ -74,7 +74,7 @@ void Source<T>::set(T const & val)
 template<typename T>
 void Source<T>::operator = (T const & val)
 {
-  set(val);
+  push(val);
 }
 
 #endif /* ARDUINO_THREADS_SOURCE_HPP_ */