Skip to content

Commit 5041b0a

Browse files
committed
Add C O OU and CN constexpressions
1 parent 431e86a commit 5041b0a

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

src/utility/SElementArduinoCloudCertificate.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,10 @@ int SElementArduinoCloudCertificate::read(SecureElement & se, ECP256Certificate
9797
}
9898

9999
cert.setSubjectCommonName(deviceId);
100-
cert.setIssuerCountryName("US");
101-
cert.setIssuerOrganizationName("Arduino LLC US");
102-
cert.setIssuerOrganizationalUnitName("IT");
103-
cert.setIssuerCommonName("Arduino");
100+
cert.setIssuerCountryName(SEACC_ISSUER_COUNTRY_NAME);
101+
cert.setIssuerOrganizationName(SEACC_ISSUER_ORGANIZATION_NAME);
102+
cert.setIssuerOrganizationalUnitName(SEACC_ISSUER_ORGANIZATIONAL_UNIT_NAME);
103+
cert.setIssuerCommonName(SEACC_ISSUER_COMMON_NAME);
104104

105105
if (!cert.setPublicKey(publicKey, ECP256_CERT_PUBLIC_KEY_LENGTH)) {
106106
return 0;
@@ -157,10 +157,10 @@ int SElementArduinoCloudCertificate::rebuild(SecureElement & se, ECP256Certifica
157157
}
158158

159159
cert.setSubjectCommonName(deviceId);
160-
cert.setIssuerCountryName("US");
161-
cert.setIssuerOrganizationName("Arduino LLC US");
162-
cert.setIssuerOrganizationalUnitName("IT");
163-
cert.setIssuerCommonName("Arduino");
160+
cert.setIssuerCountryName(SEACC_ISSUER_COUNTRY_NAME);
161+
cert.setIssuerOrganizationName(SEACC_ISSUER_ORGANIZATION_NAME);
162+
cert.setIssuerOrganizationalUnitName(SEACC_ISSUER_ORGANIZATIONAL_UNIT_NAME);
163+
cert.setIssuerCommonName(SEACC_ISSUER_COMMON_NAME);
164164
cert.setSignature(signatureBytes, sizeof(signatureBytes));
165165
cert.setAuthorityKeyId(authorityKeyIdentifierBytes, sizeof(authorityKeyIdentifierBytes));
166166
cert.setSerialNumber(serialNumberBytes, sizeof(serialNumberBytes));

src/utility/SElementArduinoCloudCertificate.h

+7
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ class SElementArduinoCloudCertificate : public SElementCertificate
3434
const String & authorityKeyIdentifier, const String & signature,
3535
const SElementArduinoCloudSlot keySlot = SElementArduinoCloudSlot::Key);
3636

37+
private:
38+
39+
static const char constexpr SEACC_ISSUER_COUNTRY_NAME[] = "US";
40+
static const char constexpr SEACC_ISSUER_ORGANIZATION_NAME[] = "Arduino LLC US";
41+
static const char constexpr SEACC_ISSUER_ORGANIZATIONAL_UNIT_NAME[] = "IT";
42+
static const char constexpr SEACC_ISSUER_COMMON_NAME[] = "Arduino";
43+
3744
};
3845

3946
#endif /* SECURE_ELEMENT_ARDUINO_CLOUD_CERTIFICATE_H_ */

0 commit comments

Comments
 (0)