Skip to content

Modernize GitHub Actions based CI to latest standard #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aentinger opened this issue Apr 20, 2021 · 6 comments · Fixed by #10
Closed

Modernize GitHub Actions based CI to latest standard #8

aentinger opened this issue Apr 20, 2021 · 6 comments · Fixed by #10
Assignees
Labels
type: enhancement Proposed improvement

Comments

@aentinger
Copy link
Contributor

No description provided.

@marqdevx
Copy link
Member

Hey!
The problem is that some sketches are specifically for the M4 or M7 so I will need to add a list to compile each sketch on the correct core.
If not its going to fail the compile allways

@marqdevx marqdevx added the type: enhancement Proposed improvement label Apr 20, 2021
@aentinger
Copy link
Contributor Author

What are the target platforms for those tutorials? I just want to avoid excluding a platform from the CI build process that actually needs to be compiled.

@per1234
Copy link
Contributor

per1234 commented Apr 20, 2021

I will need to add a list to compile each sketch on the correct core.

OK, that's definitely important. I have found this to be the most challenging part of setting up "smoke test" sketch compilation CI checks for Arduino's firmware. Without an in depth understanding of the code, it can be difficult to understand whether a compilation failure represents a genuine deficiency in the code, or is only the result of an incorrect workflow configuration causing a sketch to be compiled for a board it was never intended to be compatible with.

@marqdevx if you'll provide the list here, I'm happy to handle the update of the workflow's configuration accordingly, if that would be welcome.

@aentinger
Copy link
Contributor Author

What are the target platforms for those tutorials?

Obviously the only "Pro" platform currently available is Portenta H7 🤦 @marqdevx compiling certain sketches only for M4, others only for M7 and others again for both M4 and M7 is not a problem. If you can provide a list which sketches should be targeted in which way @per1234 can set you up with our modern CI in no time at all 😉

@marqdevx
Copy link
Member

marqdevx commented Apr 22, 2021

├─── BLE Connectivity on Portenta H7
│ └───PortentaBLE
│ PortentaBLE.ino (M7)

├───Creating a Flash-Optimised Key-Value Store
│ └───FlashKeyValue
│ FlashIAPLimits.h
│ FlashKeyValue.ino (M7)

├───Dual Core Processing
│ ├───BlinkBothCores
│ │ BlinkBothCores.ino (BOTH)
│ │
│ ├───BlinkGreenLed_M4
│ │ BlinkGreenLed_M4.ino (M4)
│ │
│ ├───BlinkRedLed
│ │ BlinkRedLed.ino (M7)
│ │
│ └───BlinkRedLed_M7
│ BlinkRedLed_M7.ino (M7)

├───Portenta H7 as a USB Host
│ └───LEDKeyboardController
│ LEDKeyboardController.ino (M7)

├───Portenta H7 as a WiFi Access Point
│ └───SimpleWebServer
│ arduino_secrets.h
│ SimpleWebServer.ino (M7)

└───Setting Up Portenta H7 For Arduino
│ └───Blink
│ Blink.ino (M7)

@marqdevx
Copy link
Member

Thanks! @per1234 @aentinger
Let me know if I can help somehow! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants