Skip to content

Commit ebd094e

Browse files
authored
Merge pull request #2 from arduino-libraries/revamp-fixes
Apply adjustments from the library review
2 parents b9d4f27 + 18786f7 commit ebd094e

File tree

12 files changed

+57
-530
lines changed

12 files changed

+57
-530
lines changed

Diff for: .github/workflows/compile-examples.yml

+11-37
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# Source: https://github.com/per1234/.github/blob/main/workflow-templates/compile-examples-private.md
12
name: Compile Examples
23

34
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
@@ -22,9 +23,9 @@ on:
2223

2324
env:
2425
UNIVERSAL_SKETCH_PATHS: |
25-
- examples/Battery
26-
- examples/Charger
27-
- examples/Standby_WakeFromPin
26+
- examples/Battery
27+
- examples/Charger
28+
- examples/Standby_WakeFromPin
2829
SKETCHES_REPORTS_PATH: sketches-reports
2930
SKETCHES_REPORTS_ARTIFACT_NAME: sketches-reports
3031

@@ -41,18 +42,17 @@ jobs:
4142

4243
matrix:
4344
board:
44-
- fqbn: arduino:renesas_portenta:portenta_c33
45-
platforms: |
46-
- name: arduino:renesas_portenta
47-
artifact-name-suffix: arduino-renesas_portenta-portenta_c33
48-
additional-sketch-paths: examples/ChargStandby_WakeFromRTC_C33er
4945
- fqbn: arduino:mbed_portenta:envie_m7
5046
platforms: |
5147
- name: arduino:mbed_portenta
5248
artifact-name-suffix: arduino-mbed_portenta-envie_m7
49+
additional-sketch-paths: examples/Standby_WakeFromRTC_C33
50+
- fqbn: arduino:renesas_portenta:portenta_c33
51+
platforms: |
52+
- name: arduino:renesas_portenta
53+
artifact-name-suffix: arduino-renesas_portenta-portenta_c33
5354
additional-sketch-paths: examples/Standby_WakeFromRTC_H7
5455

55-
5656
steps:
5757
- name: Checkout repository
5858
uses: actions/checkout@v4
@@ -64,10 +64,8 @@ jobs:
6464
fqbn: ${{ matrix.board.fqbn }}
6565
platforms: ${{ matrix.board.platforms }}
6666
libraries: |
67-
# Install the library from the local path.
6867
- source-path: ./
69-
# - name: Arduino_PF1550
70-
- source-url: https://github.com/arduino-libraries/Arduino_PF1550.git
68+
- name: Arduino_PF1550
7169
- source-url: https://github.com/arduino-libraries/Arduino_LowPowerPortentaC33.git
7270
sketch-paths: |
7371
${{ env.UNIVERSAL_SKETCH_PATHS }}
@@ -79,29 +77,5 @@ jobs:
7977
uses: actions/upload-artifact@v4
8078
with:
8179
if-no-files-found: error
80+
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
8281
path: ${{ env.SKETCHES_REPORTS_PATH }}
83-
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}
84-
85-
report-size-deltas:
86-
needs: build
87-
# Run even if some compilations failed.
88-
if: always() && github.event_name == 'pull_request'
89-
runs-on: ubuntu-latest
90-
permissions:
91-
pull-requests: write
92-
93-
steps:
94-
- name: Download sketches reports artifact
95-
id: download-artifact
96-
continue-on-error: true # If compilation failed for all boards then there are no artifacts
97-
uses: actions/download-artifact@v4
98-
with:
99-
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}
100-
path: ${{ env.SKETCHES_REPORTS_PATH }}
101-
102-
- name: Comment size deltas report to PR
103-
uses: arduino/report-size-deltas@v1
104-
# If actions/download-artifact failed, there are no artifacts to report from.
105-
if: steps.download-artifact.outcome == 'success'
106-
with:
107-
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

Diff for: examples/DeepSleep_WakeFromRTC_H7/DeepSleep_WakeFromRTC_H7.ino

-83
This file was deleted.

0 commit comments

Comments
 (0)