Skip to content

No timeout for incomplete transfer #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
megacct opened this issue Sep 28, 2024 · 3 comments
Open

No timeout for incomplete transfer #58

megacct opened this issue Sep 28, 2024 · 3 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@megacct
Copy link

megacct commented Sep 28, 2024

Could a timeout be added to downloadAndDecompress so that the function return an error if, for example, the http server terminates or comms is lost? Currently, in my project, it just hangs. Thanks

@pennam
Copy link
Contributor

pennam commented Sep 30, 2024

Hi @megacct adding a timeout to downloadAndDecompress sounds good, feel free to provide a PR for this new feature if you need it, and I will take care of reviewing and merging.

Before to start make sure your project does not hang inside socket->download(...) call, if it is like this you need to add a timeout to this function.

https://github.com/arduino/ArduinoCore-mbed/blob/931f0bbe857851d51df0e1814ab25cb5cf56c9e2/libraries/SocketWrapper/src/SocketHelpers.cpp#L159

@megacct
Copy link
Author

megacct commented Sep 30, 2024

Thanks @pennam . The changes reqd look beyond my current understanding so instead I've made use of the watchdog functionality already here. Closing the issue, regards

@megacct megacct closed this as completed Sep 30, 2024
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Oct 5, 2024
@per1234 per1234 reopened this Oct 5, 2024
@per1234
Copy link
Contributor

per1234 commented Oct 5, 2024

Even though @megacct has declined to add the missing timeout, since it was deemed useful we will leave this issue open to track the idea. Maybe someone else will be willing to take up the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants