Skip to content

Commit fb83105

Browse files
committed
Replace hard coded magic values with proper constants.
1 parent a6085f4 commit fb83105

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

src/PF1550/PF1550_Defines.h

+6
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,10 @@
6868
/* VBUS_INLIM_CNFG ************************************************************/
6969
#define REG_VBUS_INLIM_CNFG_VBUS_LIN_INLIM_mask (0xF8)
7070

71+
/* LED_PWM ********************************************************************/
72+
#define REG_LED_PWM_LED_EN_bp (7)
73+
74+
/* LED_CNFG *******************************************************************/
75+
#define REG_LED_CNFG_LEDOVRD_bp (5)
76+
7177
#endif /* PF1550_DEFINES_H_ */

src/PF1550/PF1550_Io_C33.cpp

+7-5
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
#include "Wire.h"
2828
#include "Arduino.h"
2929

30+
#include "PF1550_Defines.h"
31+
3032
/******************************************************************************
3133
CTOR/DTOR
3234
******************************************************************************/
@@ -45,11 +47,11 @@ int PF1550_Io_C33::begin()
4547
{
4648
Wire3.begin();
4749
Wire3.setClock(100000);
48-
uint8_t data[2] = { 0x9C, (1 << 7) };
49-
writeRegister(_i2c_addr, data, 2, false);
50-
data[0] = 0x9E;
51-
data[1] = (1 << 5);
52-
writeRegister(_i2c_addr, data, 2, false);
50+
51+
/* Enable LED. */
52+
setBit(Register::CHARGER_LED_PWM, REG_LED_PWM_LED_EN_bp);
53+
/* Allow LED control by software. */
54+
setBit(Register::CHARGER_LED_CNFG, REG_LED_CNFG_LEDOVRD_bp);
5355

5456
return 1;
5557
}

0 commit comments

Comments
 (0)