Add defensive programming additions

sebromero · sebromero · commit 5d7bd022eff4 · 2024-04-19T14:46:24.000+02:00
diff --git a/src/Arduino_LowPowerPortentaH7.cpp b/src/Arduino_LowPowerPortentaH7.cpp
@@ -212,7 +212,7 @@ LowPowerReturnCode LowPowerPortentaH7::checkOptionBytes() const
 
 bool LowPowerPortentaH7::wasInCPUMode(CPUMode mode) const
 {
-    auto registerValue = PWR->CPUCR;
+    const auto registerValue = PWR->CPUCR;
 
     switch (mode)
     {
@@ -224,6 +224,8 @@ bool LowPowerPortentaH7::wasInCPUMode(CPUMode mode) const
             return registerValue & PWR_CPUCR_SBF;
         case CPUMode::stop:
             return registerValue & PWR_CPUCR_STOPF;
+        default:
+            return false;
     }
 
     return false;

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ LowPowerReturnCode LowPowerPortentaH7::checkOptionBytes() const`
`212`	`212`
`213`	`213`	`bool LowPowerPortentaH7::wasInCPUMode(CPUMode mode) const`
`214`	`214`	`{`
`215`		`- auto registerValue = PWR->CPUCR;`
	`215`	`+ const auto registerValue = PWR->CPUCR;`
`216`	`216`
`217`	`217`	`switch (mode)`
`218`	`218`	`{`
`@@ -224,6 +224,8 @@ bool LowPowerPortentaH7::wasInCPUMode(CPUMode mode) const`
`224`	`224`	`return registerValue & PWR_CPUCR_SBF;`
`225`	`225`	`case CPUMode::stop:`
`226`	`226`	`return registerValue & PWR_CPUCR_STOPF;`
	`227`	`+ default:`
	`228`	`+ return false;`
`227`	`229`	`}`
`228`	`230`
`229`	`231`	`return false;`