Skip to content

Commit 72b5bf0

Browse files
committed
chore: Update error path for Notecard v7.4.1
1 parent df914ee commit 72b5bf0

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

src/Arduino_NotecardConnectionHandler.cpp

+4-11
Original file line numberDiff line numberDiff line change
@@ -661,15 +661,8 @@ bool NotecardConnectionHandler::armInterrupt (void) const
661661
// Check the response for errors
662662
if (NoteResponseError(rsp)) {
663663
const char *err = JGetString(rsp, "err");
664-
// This error must be ignored. As of LTSv6, `rearm` is not idempotent.
665-
// For now, we are counting on the fact that it is highly unlikely any
666-
// severe errors would occur in isolation. Once the Notecard firmware
667-
// is updated to support idempotent `rearm` requests, this error will
668-
// be handled as a failure.
669-
Debug.print(DBG_VERBOSE, F("%s"), err);
670-
result = true; // Ignore the error
671-
// Debug.print(DBG_ERROR, F("%s\n"), err);
672-
// result = false;
664+
Debug.print(DBG_ERROR, F("%s\n"), err);
665+
result = false;
673666
} else {
674667
result = true;
675668
}
@@ -868,8 +861,8 @@ bool NotecardConnectionHandler::updateUidCache (void)
868861
#endif
869862

870863
// This operation is safe to perform before a sync has occurred, because the
871-
// Notecard UID is static and the cloud value of Serial Number is ultimately
872-
// given preference to the value reported by the device.
864+
// Notecard UID is static and the cloud value of Serial Number is strictly
865+
// informational with regard to the host firmware operations.
873866

874867
// Read the Notecard UID from the Notehub configuration
875868
if (J *rsp = _notecard.requestAndResponse(_notecard.newRequest("hub.get"))) {

0 commit comments

Comments
 (0)