Clean up code

Author: sebromero

Diff for: src/ArduinoCellular.cpp

@@ -14,9 +14,7 @@ ArduinoCellular::ArduinoCellular() {
 }
 
 void ArduinoCellular::begin() {
-    // set sim slot
     modem.init();
-
 
     String modemInfo = this ->sendATCommand("I");
     if(modemInfo.indexOf("EC200A") > 0){
@@ -252,10 +250,10 @@ bool ArduinoCellular::enableGPS(bool assisted){
 }
 
 String ArduinoCellular::sendATCommand(const char * command, unsigned long timeout){
-    String resp;
+    String response;
     modem.sendAT(command); 
-    modem.waitResponse(timeout, resp);
-    return resp;
+    modem.waitResponse(timeout, response);
+    return response;
 }
 
 Time parseTimestamp(const String &timestampStr) {

Diff for: src/ModemInterface.cpp

@@ -4,32 +4,29 @@
 
 #include <ModemInterface.h>
 
-
 #if defined(ARDUINO_PORTENTA_C33)
+    #define ON_PIN 32 // P708 (32) is the ON pin
+
     // P602/P110/P603/P604 -> Serial1
     UART Serial1_FC(UART1_TX_PIN, UART1_RX_PIN, 61, 62);
 
     #ifdef DUMP_AT_COMMANDS
     StreamDebugger          debugger(Serial1_FC, Serial);
-    __attribute__ ((init_priority (101))) ModemInterface        modem(debugger, 32);
+    __attribute__ ((init_priority (101))) ModemInterface        modem(debugger, ON_PIN);
     #else
-    __attribute__ ((init_priority (101))) ModemInterface        modem(Serial1_FC, 32);
+    __attribute__ ((init_priority (101))) ModemInterface        modem(Serial1_FC, ON_PIN);
     #endif
 
-// P708 (32) is the ON pin
 #elif defined(ARDUINO_PORTENTA_H7_M7) || defined(CORE_CM4)
-#include "pinDefinitions.h"
-
+    #include "pinDefinitions.h"
+    #define ON_PIN PG_3 // PG3 is the ON pin
 
-// P602/P110/P603/P604 -> Serial1  
+    // P602/P110/P603/P604 -> Serial1  
     #ifdef DUMP_AT_COMMANDS
     StreamDebugger          debugger(Serial1, Serial);
-    __attribute__ ((init_priority (101))) ModemInterface modem(debugger, PinNameToIndex(PG_3));
+    __attribute__ ((init_priority (101))) ModemInterface modem(debugger, PinNameToIndex(ON_PIN));
     #else
-    __attribute__ ((init_priority (101))) ModemInterface modem(Serial1, PinNameToIndex(PG_3));
+    __attribute__ ((init_priority (101))) ModemInterface modem(Serial1, PinNameToIndex(ON_PIN));
     #endif
 
-
-
-// PG3 () is the ON pin
 #endif

Diff for: src/ModemInterface.h

@@ -26,9 +26,9 @@ class ModemInterface : public TinyGsmBG96 {
   /**
    * @brief Constructor for the ModemInterface class.
    * @param stream The stream object for communication with the modem.
-   * @param power_pin The pin number for controlling the power of the modem.
+   * @param powerPin The pin number for controlling the power of the modem.
    */
-  explicit ModemInterface(Stream& stream, int power_pin) : TinyGsmBG96(stream),stream(&stream),power_pin(power_pin) {
+  explicit ModemInterface(Stream& stream, int powerPin) : TinyGsmBG96(stream),stream(&stream),powerPin(powerPin) {
 
   };
 
@@ -38,8 +38,8 @@ class ModemInterface : public TinyGsmBG96 {
    * @return True if initialization is successful, false otherwise.
    */
   bool init(const char* pin = NULL) {
-    pinMode(power_pin, OUTPUT);
-    digitalWrite(power_pin, HIGH);
+    pinMode(powerPin, OUTPUT);
+    digitalWrite(powerPin, HIGH);
     delay(1000);
     #ifdef DUMP_AT_COMMANDS
       #if defined(ARDUINO_PORTENTA_C33)
@@ -54,7 +54,7 @@ class ModemInterface : public TinyGsmBG96 {
 
 public:
   Stream* stream; /**< The stream object for communication with the modem. */
-  int power_pin; /**< The pin number for controlling the power of the modem. */
+  int powerPin; /**< The pin number for controlling the power of the modem. */
 };
 
 /**