Skip to content

consider reordering the code #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ku3i opened this issue May 8, 2024 · 0 comments
Open

consider reordering the code #48

ku3i opened this issue May 8, 2024 · 0 comments
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@ku3i
Copy link

ku3i commented May 8, 2024

https://github.com/arduino-libraries/Arduino_BQ24195/blob/c7cb8e8b5e8c0a9d7b5dcac8e544ea127856b237/src/BQ24195.cpp#L363C9-L363C40

In the case of setting a value e.g. larger than 3.0f, the variable current_val is written 7 times. Reordering the comparison should be considered.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ku3i @per1234