Skip to content

Commit 7458540

Browse files
authored
Fix regression: report size delta size on PR. (#48)
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
1 parent d90a374 commit 7458540

File tree

3 files changed

+20
-28
lines changed

3 files changed

+20
-28
lines changed

.github/workflows/compile-examples.yml

+19-4
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ on:
1818
workflow_dispatch:
1919
repository_dispatch:
2020

21+
env:
22+
SKETCHES_REPORTS_PATH: sketches-reports
23+
2124
jobs:
22-
build:
25+
compile:
2326
name: ${{ matrix.board.fqbn }}
2427
runs-on: ubuntu-latest
2528

26-
env:
27-
SKETCHES_REPORTS_PATH: sketches-reports
28-
2929
strategy:
3030
fail-fast: false
3131

@@ -102,3 +102,18 @@ jobs:
102102
if-no-files-found: error
103103
path: ${{ env.SKETCHES_REPORTS_PATH }}
104104
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
105+
106+
report:
107+
needs: compile
108+
if: github.event_name == 'pull_request'
109+
runs-on: ubuntu-latest
110+
111+
steps:
112+
- name: Download sketches reports artifacts
113+
uses: actions/download-artifact@v4
114+
with:
115+
path: ${{ env.SKETCHES_REPORTS_PATH }}
116+
117+
- uses: arduino/report-size-deltas@v1
118+
with:
119+
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

.github/workflows/report-size-deltas.yml

-24
This file was deleted.

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.idea/

0 commit comments

Comments
 (0)