Skip to content

Giga R1 WiFi works with a small change #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
esp32beans opened this issue Mar 27, 2023 · 3 comments · Fixed by #86
Closed

Giga R1 WiFi works with a small change #85

esp32beans opened this issue Mar 27, 2023 · 3 comments · Fixed by #86
Labels
conclusion: resolved Issue was resolved topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project

Comments

@esp32beans
Copy link

I tested ver 0.1.6 using Giga R1 WiFi. Only a small change is required to make the examples work. I removed the check for ESP32 because Giga also uses WiFi.h.

Old

#elif defined(ESP32)
  #include <WiFi.h>
#endif

New

#else
  #include <WiFi.h>
#endif

Is it too much to hope new boards will implement the standard Arduino WiFi API? For example, Uno R4 will have a WiFi option. Would be nice to avoid releasing a new version of the library whenever a new board with WiFi appears.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: documentation Related to documentation for the project labels Mar 27, 2023
@aentinger
Copy link
Contributor

I've fixed this library.

It would probably pay off to do a new release of this library, any objections @pennam ?

@per1234 per1234 added the conclusion: resolved Issue was resolved label Mar 27, 2023
@pennam
Copy link
Contributor

pennam commented Mar 27, 2023

Not at all. Thanks @aentinger 👍

@aentinger
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants