Skip to content

Commit d599067

Browse files
authored
Fix regression: report size delta size on PR. (#143)
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
1 parent be8f274 commit d599067

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

Diff for: .github/workflows/compile-examples.yml

+19-2
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,15 @@ on:
1919
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_dispatch
2020
workflow_dispatch:
2121

22+
env:
23+
SKETCHES_REPORTS_PATH: sketches-reports
24+
2225
jobs:
23-
build:
26+
compile:
2427
name: ${{ matrix.board.fqbn }}
2528
runs-on: ubuntu-latest
2629

2730
env:
28-
SKETCHES_REPORTS_PATH: sketches-reports
2931
# Libraries to install for all boards
3032
UNIVERSAL_LIBRARIES: |
3133
# Install the ArduinoModbus library from the local path
@@ -117,3 +119,18 @@ jobs:
117119
if-no-files-found: error
118120
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
119121
path: ${{ env.SKETCHES_REPORTS_PATH }}
122+
123+
report:
124+
needs: compile
125+
if: github.event_name == 'pull_request'
126+
runs-on: ubuntu-latest
127+
128+
steps:
129+
- name: Download sketches reports artifacts
130+
uses: actions/download-artifact@v4
131+
with:
132+
path: ${{ env.SKETCHES_REPORTS_PATH }}
133+
134+
- uses: arduino/report-size-deltas@v1
135+
with:
136+
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

Diff for: .github/workflows/report-size-deltas.yml

-18
This file was deleted.

Diff for: .gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.idea/

0 commit comments

Comments
 (0)