Skip to content

Port ArduinoIoTCloud CI from Travis to Arduino GitHub Actions #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aentinger opened this issue Apr 8, 2020 · 4 comments
Closed

Port ArduinoIoTCloud CI from Travis to Arduino GitHub Actions #112

aentinger opened this issue Apr 8, 2020 · 4 comments
Assignees
Labels
type: enhancement Proposed improvement

Comments

@aentinger
Copy link
Contributor

and add the size-report feature for sketch ArduinoIoTCloud_Travis_CI.

@aentinger aentinger added the type: enhancement Proposed improvement label Apr 8, 2020
@per1234
Copy link
Contributor

per1234 commented Apr 10, 2020

This is currently blocked by arduino/actions#24. I'm starting work on that now.

@per1234
Copy link
Contributor

per1234 commented Apr 15, 2020

Question: the Travis CI configuration installs the library dependencies by cloning then checking out the latest tag. The reason for doing this instead of using Library Manager is because, between waiting for the indexer job to pick up a new release and for the CDN caches to update the index, it can take a significant amount of time before the release of one of the library dependencies becomes available for installation via Library Manager.

The arduino/actions/libraries/compile-examples action currently only allows installing libraries via Library Manager. Will that be a problem?

@aentinger
Copy link
Contributor Author

Good catch 👍 It's not going to be a problem right now but there might be situations (again) where it could be highly annoying. Not always a new library is released although there have been changes to master. All in all it would be good if we could also install libraries directly from their github repository but I don't see it as a roadblock right now.

@per1234
Copy link
Contributor

per1234 commented Jun 12, 2020

Update regarding this:

the Travis CI configuration installs the library dependencies by cloning then checking out the latest tag. The reason for doing this instead of using Library Manager is because, between waiting for the indexer job to pick up a new release and for the CDN caches to update the index, it can take a significant amount of time before the release of one of the library dependencies becomes available for installation via Library Manager.

The arduino/actions/libraries/compile-examples action currently only allows installing libraries via Library Manager. Will that be a problem?

arduino/actions#48 added support for installing libraries by cloning a repository and checking them out to the latest tag. For example:

env:
  UNIVERSAL_LIBRARIES: |
    - source-url: https://github.com/arduino-libraries/Arduino_ConnectionHandler.git
      version: latest
    - source-url: https://github.com/arduino-libraries/Arduino_DebugUtils.git
      version: latest
    - source-url: https://github.com/arduino-libraries/ArduinoMqttClient.git
      version: latest

Regarding this:

Not always a new library is released although there have been changes to master. All in all it would be good if we could also install libraries directly from their github repository but I don't see it as a roadblock right now.

It's also now possible to leave the repository sourced library dependencies checked out to the tip of the default (i.e., master) branch if you prefer to test against the development version rather than the release version. For example:

env:
  UNIVERSAL_LIBRARIES: |
    - source-url: https://github.com/arduino-libraries/Arduino_ConnectionHandler.git
    - source-url: https://github.com/arduino-libraries/Arduino_DebugUtils.git
    - source-url: https://github.com/arduino-libraries/ArduinoMqttClient.git

So if you ever find the current system of installing the library dependencies via Library Manager is inconvenient and want to change this, just let me know and I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants