Using 'const' where feasible (const correctness)

Author: aentinger

src/ArduinoIoTCloud.cpp

@@ -112,7 +112,7 @@ void ArduinoIoTCloudClass::update()
   update(MAX_RETRIES, RECONNECTION_TIMEOUT);
 }
 
-bool ArduinoIoTCloudClass::mqttReconnect(int maxRetries, int timeout)
+bool ArduinoIoTCloudClass::mqttReconnect(int const maxRetries, int const timeout)
 {
   // Counter for reconnection retries
   int retries = 0;
@@ -136,11 +136,11 @@ bool ArduinoIoTCloudClass::mqttReconnect(int maxRetries, int timeout)
   return true;
 }
 
-void ArduinoIoTCloudClass::update(int reconnectionMaxRetries, int reconnectionTimeoutMs)
+void ArduinoIoTCloudClass::update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs)
 {
   // Method's argument controls
-  int maxRetries = (reconnectionMaxRetries > 0) ? reconnectionMaxRetries : MAX_RETRIES;
-  int timeout = (reconnectionTimeoutMs > 0) ? reconnectionTimeoutMs : RECONNECTION_TIMEOUT;
+  int const maxRetries = (reconnectionMaxRetries > 0) ? reconnectionMaxRetries : MAX_RETRIES;
+  int const timeout    = (reconnectionTimeoutMs  > 0) ? reconnectionTimeoutMs  : RECONNECTION_TIMEOUT;
 
   // If the reconnect() culd not establish the connection, return the control to the user sketch
   if (!mqttReconnect(maxRetries, timeout))
@@ -150,7 +150,7 @@ void ArduinoIoTCloudClass::update(int reconnectionMaxRetries, int reconnectionTi
   _mqttClient.loop();
 
   uint8_t data[MQTT_BUFFER_SIZE];
-  int length = Thing.poll(data, sizeof(data));
+  int const length = Thing.poll(data, sizeof(data));
   if (length > 0) {
     writeProperties(data, length);
   }
@@ -186,22 +186,22 @@ int ArduinoIoTCloudClass::connected()
   return _mqttClient.connected();
 }
 
-int ArduinoIoTCloudClass::writeProperties(const byte data[], int length)
+int ArduinoIoTCloudClass::writeProperties(const byte data[], int const length)
 {
   return _mqttClient.publish(_dataTopicOut.c_str(), (const char*)data, length);
 }
 
-int ArduinoIoTCloudClass::writeStdout(const byte data[], int length)
+int ArduinoIoTCloudClass::writeStdout(const byte data[], int const length)
 {
   return _mqttClient.publish(_stdoutTopic.c_str(), (const char*)data, length);
 }
 
-void ArduinoIoTCloudClass::onMessage(MQTTClient* /*client*/, char topic[], char bytes[], int length)
+void ArduinoIoTCloudClass::onMessage(MQTTClient* /*client*/, char topic[], char bytes[], int const length)
 {
   ArduinoCloud.handleMessage(topic, bytes, length);
 }
 
-void ArduinoIoTCloudClass::handleMessage(char topic[], char bytes[], int length)
+void ArduinoIoTCloudClass::handleMessage(char topic[], char bytes[], int const length)
 {
   if (_stdinTopic == topic) {
     CloudSerial.appendStdin((uint8_t*)bytes, length);

src/ArduinoIoTCloud.h

@@ -35,7 +35,7 @@ class ArduinoIoTCloudClass {
   void update();
 
   // defined for users who want to specify max reconnections reties and timeout between them
-  void update(int reconnectionMaxRetries, int reconnectionTimeoutMs);
+  void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs);
   // It must be a user defined function, in order to avoid ArduinoCloud include specific WiFi file
   // in this case this library is independent from the WiFi one
   void onGetTime(unsigned long(*)(void));
@@ -52,16 +52,16 @@ class ArduinoIoTCloudClass {
 
 protected:
   friend class CloudSerialClass;
-  int writeStdout(const byte data[], int length);
-  int writeProperties(const byte data[], int length);
+  int writeStdout(const byte data[], int const length);
+  int writeProperties(const byte data[], int const length);
   // Used to initialize MQTTClient
   void mqttClientBegin(Client& net);
   // Function in charge of perform MQTT reconnection, basing on class parameters(retries,and timeout)
-  bool mqttReconnect(int maxRetries, int timeout);
+  bool mqttReconnect(int const maxRetries, int const timeout);
 
 private:
-  static void onMessage(MQTTClient *client, char topic[], char bytes[], int length);
-  void handleMessage(char topic[], char bytes[], int length);
+  static void onMessage(MQTTClient *client, char topic[], char bytes[], int const length);
+  void handleMessage(char topic[], char bytes[], int const length);
 
   String _id;
   String _brokerAddress;