Fix threshold check

pennam · pennam · commit bd97dbeb762f · 2021-09-29T15:25:01.000+02:00
diff --git a/src/property/types/CloudUnsignedInt.h b/src/property/types/CloudUnsignedInt.h
@@ -44,7 +44,7 @@ class CloudUnsignedInt : public Property {
       return _value;
     }
     virtual bool isDifferentFromCloud() {
-      return _value != _cloud_value && (abs(_value - _cloud_value) >= Property::_min_delta_property);
+      return _value != _cloud_value && ((max(_value , _cloud_value) - min(_value , _cloud_value)) >= Property::_min_delta_property);
     }
     virtual void fromCloudToLocal() {
       _value = _cloud_value;
diff --git a/src/property/types/CloudWrapperUnsignedInt.h b/src/property/types/CloudWrapperUnsignedInt.h
@@ -37,7 +37,7 @@ class CloudWrapperUnsignedInt : public CloudWrapperBase {
   public:
     CloudWrapperUnsignedInt(unsigned int& v) : _primitive_value(v), _cloud_value(v), _local_value(v) {}
     virtual bool isDifferentFromCloud() {
-      return _primitive_value != _cloud_value && (abs(_primitive_value - _cloud_value) >= Property::_min_delta_property);
+      return _primitive_value != _cloud_value && ((max(_primitive_value , _cloud_value) - min(_primitive_value , _cloud_value)) >= Property::_min_delta_property);
     }
     virtual void fromCloudToLocal() {
       _primitive_value = _cloud_value;

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class CloudUnsignedInt : public Property {`
`44`	`44`	`return _value;`
`45`	`45`	`}`
`46`	`46`	`virtual bool isDifferentFromCloud() {`
`47`		`- return _value != _cloud_value && (abs(_value - _cloud_value) >= Property::_min_delta_property);`
	`47`	`+ return _value != _cloud_value && ((max(_value , _cloud_value) - min(_value , _cloud_value)) >= Property::_min_delta_property);`
`48`	`48`	`}`
`49`	`49`	`virtual void fromCloudToLocal() {`
`50`	`50`	`_value = _cloud_value;`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class CloudWrapperUnsignedInt : public CloudWrapperBase {`
`37`	`37`	`public:`
`38`	`38`	`CloudWrapperUnsignedInt(unsigned int& v) : _primitive_value(v), _cloud_value(v), _local_value(v) {}`
`39`	`39`	`virtual bool isDifferentFromCloud() {`
`40`		`- return _primitive_value != _cloud_value && (abs(_primitive_value - _cloud_value) >= Property::_min_delta_property);`
	`40`	`+ return _primitive_value != _cloud_value && ((max(_primitive_value , _cloud_value) - min(_primitive_value , _cloud_value)) >= Property::_min_delta_property);`
`41`	`41`	`}`
`42`	`42`	`virtual void fromCloudToLocal() {`
`43`	`43`	`_primitive_value = _cloud_value;`