Skip to content

Commit 8ae88fc

Browse files
zfieldspennam
zfields
and
pennam
committed
Apply suggestions from code review
Co-authored-by: Mattia Pennasilico <[email protected]>
1 parent ab43cf3 commit 8ae88fc

15 files changed

+14
-34
lines changed

‎examples/ArduinoIoTCloud-Advanced/ArduinoIoTCloud-Advanced.ino

-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010
- https://github.com/arduino-libraries/ArduinoIoTCloud#what
1111
*/
1212

13-
#include <ArduinoIoTCloud.h>
14-
15-
#include "arduino_secrets.h"
1613
#include "thingProperties.h"
1714

1815
void setup() {

‎examples/ArduinoIoTCloud-Advanced/arduino_secrets.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include <AIoTC_Config.h>
1+
#include <Arduino_ConnectionHandler.h>
22

33
/* A complete list of supported boards with WiFi is available here:
44
* https://github.com/arduino-libraries/ArduinoIoTCloud/#what

‎examples/ArduinoIoTCloud-Advanced/thingProperties.h

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include <ArduinoIoTCloud.h>
22
#include <Arduino_ConnectionHandler.h>
3-
43
#include "arduino_secrets.h"
54

65
#if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \

‎examples/ArduinoIoTCloud-Basic/ArduinoIoTCloud-Basic.ino

-3
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
- https://github.com/arduino-libraries/ArduinoIoTCloud#what
1515
*/
1616

17-
#include <ArduinoIoTCloud.h>
18-
19-
#include "arduino_secrets.h"
2017
#include "thingProperties.h"
2118

2219
#if !defined(LED_BUILTIN) && !defined(ARDUINO_NANO_ESP32)

‎examples/ArduinoIoTCloud-Basic/arduino_secrets.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include <AIoTC_Config.h>
1+
#include <Arduino_ConnectionHandler.h>
22

33
/* A complete list of supported boards with WiFi is available here:
44
* https://github.com/arduino-libraries/ArduinoIoTCloud/#what

‎examples/ArduinoIoTCloud-Basic/thingProperties.h

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include <ArduinoIoTCloud.h>
22
#include <Arduino_ConnectionHandler.h>
3-
43
#include "arduino_secrets.h"
54

65
#if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \

‎examples/ArduinoIoTCloud-Callbacks/ArduinoIoTCloud-Callbacks.ino

-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
- https://github.com/arduino-libraries/ArduinoIoTCloud#what
2727
*/
2828

29-
#include <ArduinoIoTCloud.h>
30-
31-
#include "arduino_secrets.h"
3229
#include "thingProperties.h"
3330

3431
void setup() {

‎examples/ArduinoIoTCloud-Callbacks/arduino_secrets.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include <AIoTC_Config.h>
1+
#include <Arduino_ConnectionHandler.h>
22

33
/* A complete list of supported boards with WiFi is available here:
44
* https://github.com/arduino-libraries/ArduinoIoTCloud/#what

‎examples/ArduinoIoTCloud-Callbacks/thingProperties.h

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include <ArduinoIoTCloud.h>
22
#include <Arduino_ConnectionHandler.h>
3-
43
#include "arduino_secrets.h"
54

65
#if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \

‎examples/ArduinoIoTCloud-DeferredOTA/ArduinoIoTCloud-DeferredOTA.ino

-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
- https://github.com/arduino-libraries/ArduinoIoTCloud/#ota
1717
*/
1818

19-
#include <ArduinoIoTCloud.h>
20-
21-
#include "arduino_secrets.h"
2219
#include "thingProperties.h"
2320

2421
#if !defined(LED_BUILTIN) && !defined(ARDUINO_NANO_ESP32)

‎examples/ArduinoIoTCloud-DeferredOTA/arduino_secrets.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include <AIoTC_Config.h>
1+
#include <Arduino_ConnectionHandler.h>
22

33
/* A complete list of supported boards with WiFi is available here:
44
* https://github.com/arduino-libraries/ArduinoIoTCloud/#what

‎examples/ArduinoIoTCloud-DeferredOTA/thingProperties.h

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include <ArduinoIoTCloud.h>
22
#include <Arduino_ConnectionHandler.h>
3-
43
#include "arduino_secrets.h"
54

65
#if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_ETHERNET))

‎examples/ArduinoIoTCloud-Schedule/ArduinoIoTCloud-Schedule.ino

-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
77
*/
88

9-
#include <ArduinoIoTCloud.h>
10-
11-
#include "arduino_secrets.h"
129
#include "thingProperties.h"
1310

1411
#if !defined(LED_BUILTIN) && !defined(ARDUINO_NANO_ESP32)

‎examples/ArduinoIoTCloud-Schedule/arduino_secrets.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include <AIoTC_Config.h>
1+
#include <Arduino_ConnectionHandler.h>
22

33
/* A complete list of supported boards with WiFi is available here:
44
* https://github.com/arduino-libraries/ArduinoIoTCloud/#what

‎examples/ArduinoIoTCloud-Schedule/thingProperties.h

+9-10
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include <ArduinoIoTCloud.h>
22
#include <Arduino_ConnectionHandler.h>
3-
43
#include "arduino_secrets.h"
54

65
#if !(defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_LORA) || \
@@ -29,16 +28,16 @@ void initProperties() {
2928
ArduinoCloud.setSecretDeviceKey(SECRET_DEVICE_KEY);
3029
#endif
3130
#if defined(BOARD_HAS_WIFI) || defined(BOARD_HAS_GSM) || defined(BOARD_HAS_NB) || defined(BOARD_HAS_ETHERNET) || defined(BOARD_HAS_CATM1_NBIOT)
32-
ArduinoCloud.addProperty(switchButton, Permission::Write).onUpdate(nullptr);
33-
ArduinoCloud.addProperty(oneShot, Permission::ReadWrite).onUpdate(nullptr);
34-
ArduinoCloud.addProperty(minute, Permission::ReadWrite).onUpdate(nullptr);
35-
ArduinoCloud.addProperty(hourly, Permission::ReadWrite).onUpdate(nullptr);
36-
ArduinoCloud.addProperty(daily, Permission::ReadWrite).onUpdate(nullptr);
37-
ArduinoCloud.addProperty(weekly, Permission::ReadWrite).onUpdate(nullptr);
38-
ArduinoCloud.addProperty(monthly, Permission::ReadWrite).onUpdate(nullptr);
39-
ArduinoCloud.addProperty(yearly, Permission::ReadWrite).onUpdate(nullptr);
31+
ArduinoCloud.addProperty(switchButton, Permission::Write);
32+
ArduinoCloud.addProperty(oneShot, Permission::ReadWrite);
33+
ArduinoCloud.addProperty(minute, Permission::ReadWrite);
34+
ArduinoCloud.addProperty(hourly, Permission::ReadWrite);
35+
ArduinoCloud.addProperty(daily, Permission::ReadWrite);
36+
ArduinoCloud.addProperty(weekly, Permission::ReadWrite);
37+
ArduinoCloud.addProperty(monthly, Permission::ReadWrite);
38+
ArduinoCloud.addProperty(yearly, Permission::ReadWrite);
4039
#elif defined(BOARD_HAS_LORA)
41-
ArduinoCloud.addProperty(switchButton, 1, Permission::Write).onUpdate(nullptr);
40+
ArduinoCloud.addProperty(switchButton, 1, Permission::Write);
4241
#endif
4342
}
4443

0 commit comments

Comments
 (0)