Bugfix: Wrong operand order within comparison leads to never attempting reconnect.

aentinger · aentinger · commit 75abde643b94 · 2021-04-28T09:53:48.000+02:00
diff --git a/src/ArduinoIoTCloudTCP.cpp b/src/ArduinoIoTCloudTCP.cpp
@@ -335,7 +335,7 @@ ArduinoIoTCloudTCP::State ArduinoIoTCloudTCP::handle_ConnectPhy()
   if (_connection->check() == NetworkConnectionState::CONNECTED)
   {
     bool const is_retry_attempt = (_last_connection_attempt_cnt > 0);
-    if (!is_retry_attempt || (is_retry_attempt && (_next_connection_attempt_tick > millis())))
+    if (!is_retry_attempt || (is_retry_attempt && (millis() > _next_connection_attempt_tick)))
       return State::SyncTime;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ ArduinoIoTCloudTCP::State ArduinoIoTCloudTCP::handle_ConnectPhy()`
`335`	`335`	`if (_connection->check() == NetworkConnectionState::CONNECTED)`
`336`	`336`	`{`
`337`	`337`	`bool const is_retry_attempt = (_last_connection_attempt_cnt > 0);`
`338`		`- if (!is_retry_attempt \|\| (is_retry_attempt && (_next_connection_attempt_tick > millis())))`
	`338`	`+ if (!is_retry_attempt \|\| (is_retry_attempt && (millis() > _next_connection_attempt_tick)))`
`339`	`339`	`return State::SyncTime;`
`340`	`340`	`}`
`341`	`341`