Add encode test to increase coverage

Author: pennam

extras/test/src/test_command_encode.cpp

@@ -35,8 +35,10 @@ SCENARIO("Test the encoding of command messages") {
     Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
 
     uint8_t expected_result[] = {
-      0xda, 0x00, 0x01, 0x00, 0x00, 0x81, 0x58, 0x20, 0x01, 0x02, 0x03, 0x04, 0x00, 0x00, 0x00, 0x00,
-      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+      0xda, 0x00, 0x01, 0x00, 0x00, 0x81, 0x58, 0x20,
+      0x01, 0x02, 0x03, 0x04, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
       0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
     };
 
@@ -70,7 +72,8 @@ SCENARIO("Test the encoding of command messages") {
     Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
 
     uint8_t expected_result[] = {
-      0xda, 0x00, 0x01, 0x03, 0x00, 0x81, 0x68, 0x74, 0x68, 0x69, 0x6e, 0x67, 0x5f, 0x69, 0x64
+      0xda, 0x00, 0x01, 0x03, 0x00, 0x81, 0x68, 0x74,
+      0x68, 0x69, 0x6e, 0x67, 0x5f, 0x69, 0x64
     };
 
     // Test the encoding is
@@ -130,7 +133,8 @@ SCENARIO("Test the encoding of command messages") {
     Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
 
     uint8_t expected_result[] = {
-      0xda, 0x00, 0x01, 0x07, 0x00, 0x81, 0x65, 0x32, 0x2e, 0x30, 0x2e, 0x30
+      0xda, 0x00, 0x01, 0x07, 0x00, 0x81, 0x65, 0x32,
+      0x2e, 0x30, 0x2e, 0x30
     };
 
     // Test the encoding is
@@ -167,8 +171,10 @@ SCENARIO("Test the encoding of command messages") {
     Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
 
     uint8_t expected_result[] = {
-      0xda, 0x00, 0x01, 0x02, 0x00, 0x84, 0x50, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
-      0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0xe1, 0x20, 0x18, 0x64
+      0xda, 0x00, 0x01, 0x02, 0x00, 0x84, 0x50, 0x00,
+      0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
+      0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0xe1,
+      0x20, 0x18, 0x64
     };
 
     // Test the encoding is
@@ -212,4 +218,105 @@ SCENARIO("Test the encoding of command messages") {
       REQUIRE(memcmp(buffer, expected_result, sizeof(expected_result)) == 0);
     }
   }
+
+  /****************************************************************************/
+
+  WHEN("Encode the ThingUpdateCmdId message")
+  {
+    ThingUpdateCmd command;
+    command.c.id = CommandId::ThingUpdateCmdId;
+
+    String thing_id = "e4494d55-872a-4fd2-9646-92f87949394c";
+    strcpy(command.params.thing_id, thing_id.c_str());
+
+    uint8_t buffer[512];
+    size_t bytes_encoded = sizeof(buffer);
+
+    CBORMessageEncoder encoder;
+    Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
+
+    THEN("The encoding is unsuccessful - ThingUpdateCmdId is not supported") {
+      REQUIRE(err == Encoder::Status::Error);
+    }
+  }
+
+  /****************************************************************************/
+
+  WHEN("Encode the SetTimezoneCommand message")
+  {
+    TimezoneCommandDown command;
+    command.c.id = CommandId::TimezoneCommandDownId;
+
+    command.params.offset = 1708963873;
+    command.params.until = 2024579473;
+
+    uint8_t buffer[512];
+    size_t bytes_encoded = sizeof(buffer);
+
+    CBORMessageEncoder encoder;
+    Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
+
+    THEN("The encoding is unsuccessful - SetTimezoneCommand is not supported") {
+      REQUIRE(err == Encoder::Status::Error);
+    }
+  }
+
+  /****************************************************************************/
+
+  WHEN("Encode the LastValuesUpdateCmd message")
+  {
+    LastValuesUpdateCmd command;
+    command.c.id = CommandId::LastValuesUpdateCmdId;
+
+    command.params.length = 13;
+    uint8_t last_values[13] = {0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
+                               0x08, 0x09, 0x10, 0x11, 0x12};
+    command.params.last_values = last_values;
+
+    uint8_t buffer[512];
+    size_t bytes_encoded = sizeof(buffer);
+
+    CBORMessageEncoder encoder;
+    Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
+
+    THEN("The encoding is unsuccessful - LastValuesUpdateCmd is not supported") {
+      REQUIRE(err == Encoder::Status::Error);
+    }
+  }
+
+  /****************************************************************************/
+
+  WHEN("Encode the OtaUpdateCmdDown message")
+  {
+    OtaUpdateCmdDown command;
+    command.c.id = CommandId::OtaUpdateCmdDownId;
+
+    uint8_t buffer[512];
+    size_t bytes_encoded = sizeof(buffer);
+
+    CBORMessageEncoder encoder;
+    Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
+
+    THEN("The encoding is unsuccessful - OtaUpdateCmdDown is not supported") {
+      REQUIRE(err == Encoder::Status::Error);
+    }
+  }
+
+  /****************************************************************************/
+
+  WHEN("Encode a message with unknown command Id")
+  {
+    OtaUpdateCmdDown command;
+    command.c.id = CommandId::UnknownCmdId;
+
+    uint8_t buffer[512];
+    size_t bytes_encoded = sizeof(buffer);
+
+    CBORMessageEncoder encoder;
+    Encoder::Status err = encoder.encode((Message*)&command, buffer, bytes_encoded);
+
+    THEN("The encoding is unsuccessful - OtaUpdateCmdDown is not supported") {
+      REQUIRE(err == Encoder::Status::Error);
+    }
+  }
 }