[CM-474] Notify user if thing id is wrong / thing does not exist

Author: aentinger

src/ArduinoIoTCloud.cpp

@@ -30,6 +30,11 @@ const static int compressedCertSlot                        = 10;
 const static int serialNumberAndAuthorityKeyIdentifierSlot = 11;
 const static int thingIdSlot                               = 12;
 
+constexpr static int CONNECT_FAILURE_SUBSCRIBE = -1;
+constexpr static int CONNECT_FAILURE           = 0;
+constexpr static int CONNECT_SUCCESS           = 1;
+
+
 static ConnectionManager *getTimeConnection = NULL;
 
 static unsigned long getTime() {
@@ -182,16 +187,23 @@ int ArduinoIoTCloudClass::connect()
   // Username: device id
   // Password: empty
   if (!_mqttClient->connect(_brokerAddress.c_str(), _brokerPort)) {
-    return 0;
+    return CONNECT_FAILURE;
+  }
+
+  bool is_subscribe_error = false;
+
+  if(_mqttClient->subscribe(_stdinTopic   ) == 0) is_subscribe_error = true;
+  if(_mqttClient->subscribe(_dataTopicIn  ) == 0) is_subscribe_error = true;
+  if(_mqttClient->subscribe(_shadowTopicIn) == 0) is_subscribe_error = true;
+
+  if(is_subscribe_error) {
+    return CONNECT_FAILURE_SUBSCRIBE;
   }
-  _mqttClient->subscribe(_stdinTopic);
-  _mqttClient->subscribe(_dataTopicIn);
-  _mqttClient->subscribe(_shadowTopicIn);
 
   _syncStatus = ArduinoIoTSynchronizationStatus::SYNC_STATUS_WAIT_FOR_CLOUD_VALUES;
   _lastSyncRequestTickTime = 0;
 
-  return 1;
+  return CONNECT_SUCCESS;
 }
 
 bool ArduinoIoTCloudClass::disconnect()
@@ -402,15 +414,17 @@ void ArduinoIoTCloudClass::connectionCheck()
       }
       break;
     case IOT_STATUS_CLOUD_CONNECTING:
-      int arduinoIoTConnectionAttempt;
-      arduinoIoTConnectionAttempt = connect();
-      sprintf(msgBuffer, "ArduinoCloud.connect(): %d", arduinoIoTConnectionAttempt);
+      int const ret_code_connect = connect();
+      sprintf(msgBuffer, "ArduinoCloud.connect(): %d", ret_code_connect);
       debugMessage(msgBuffer, 4);
-      if (arduinoIoTConnectionAttempt == 1) {
+      if (ret_code_connect == CONNECT_SUCCESS) {
         setIoTConnectionState(IOT_STATUS_CLOUD_CONNECTED);
         CloudSerial.begin(9600);
         CloudSerial.println("Hello from Cloud Serial!");
       }
+      else if (ret_code_connect == CONNECT_FAILURE_SUBSCRIBE) {
+        Serial.println("ERROR - Please verify your THING ID");
+      }
       #ifdef ARDUINO_ARCH_SAMD
         unsigned long const epoch = getTime();
         if (epoch!=0)