Skip to content

Fixed large file size update for Arduino OTA (no more gives negative file size value due to overflow) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed large file size update for Arduino OTA (no more gives negative file size value due to overflow) #103

wants to merge 2 commits into from

Conversation

ibrahimSP
Copy link

No description provided.

@ibrahimSP
Update HttpClient.h
c39fda4 
fixed large file size for Arduino OTA issue
@ibrahimSP
Update HttpClient.cpp
328f27b
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Memory usage change @ 328f27b

Board flash % RAM for global variables %
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicAuthGet
flash		 % examples/BasicAuthGet
RAM for global variables		 % examples/CustomHeader
flash		 % examples/CustomHeader
RAM for global variables		 % examples/DweetGet
flash		 % examples/DweetGet
RAM for global variables		 % examples/DweetPost
flash		 % examples/DweetPost
RAM for global variables		 % examples/HueBlink
flash		 % examples/HueBlink
RAM for global variables		 % examples/PostWithHeaders
flash		 % examples/PostWithHeaders
RAM for global variables		 % examples/SimpleDelete
flash		 % examples/SimpleDelete
RAM for global variables		 % examples/SimpleGet
flash		 % examples/SimpleGet
RAM for global variables		 % examples/SimpleHttpExample
flash		 % examples/SimpleHttpExample
RAM for global variables		 % examples/SimplePost
flash		 % examples/SimplePost
RAM for global variables		 % examples/SimplePut
flash		 % examples/SimplePut
RAM for global variables		 % examples/SimpleWebSocket
flash		 % examples/SimpleWebSocket
RAM for global variables		 %
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@JAndrassy JAndrassy mentioned this pull request Jun 10, 2021
Closed
@andreagilardoni
Copy link

@ibrahimSP thanks for your contribution, we have already merged the same fix with this PR #90, thus I am closing this one.

@per1234 per1234 added type: imperfection Perceived defect in any part of project conclusion: duplicate Has already been submitted topic: code Related to content of the project itself labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibrahimSP @CLAassistant @andreagilardoni @per1234