Skip to content

Commit 4bbf688

Browse files
committed
Fix regression: report size delta size on PR.
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
1 parent 01ac2e5 commit 4bbf688

File tree

2 files changed

+23
-28
lines changed

2 files changed

+23
-28
lines changed

.github/workflows/compile-examples.yml

+23-4
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@ on:
2020
workflow_dispatch:
2121
repository_dispatch:
2222

23+
env:
24+
# It's convenient to set variables for values used multiple times in the workflow.
25+
SKETCHES_REPORTS_PATH: sketches-reports
26+
2327
jobs:
24-
build:
28+
compile:
2529
name: ${{ matrix.board.fqbn }}
2630
runs-on: ubuntu-latest
2731

28-
env:
29-
SKETCHES_REPORTS_PATH: sketches-reports
30-
3132
strategy:
3233
fail-fast: false
3334

@@ -72,3 +73,21 @@ jobs:
7273
if-no-files-found: error
7374
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
7475
path: ${{ env.SKETCHES_REPORTS_PATH }}
76+
77+
# When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
78+
report:
79+
needs: compile # Wait for the compile job to finish to get the data for the report
80+
if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
81+
runs-on: ubuntu-latest
82+
83+
steps:
84+
# This step is needed to get the size data produced by the compile jobs
85+
- name: Download sketches reports artifacts
86+
uses: actions/download-artifact@v4
87+
with:
88+
# All workflow artifacts will be downloaded to this location.
89+
path: ${{ env.SKETCHES_REPORTS_PATH }}
90+
91+
- uses: arduino/report-size-deltas@v1
92+
with:
93+
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

.github/workflows/report-size-deltas.yml

-24
This file was deleted.

0 commit comments

Comments
 (0)