Skip to content

Incorrect change applied for ARDUINO_GIGA #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paulvha opened this issue Mar 27, 2023 · 0 comments
Closed

Incorrect change applied for ARDUINO_GIGA #292

paulvha opened this issue Mar 27, 2023 · 0 comments
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@paulvha
Copy link

paulvha commented Mar 27, 2023

In order to support ARDUINO_GIGA a number of changes had been applied to create version 1.3.3m, documented on f852716.

There is an error in those changes, copy/paste is applied to quickly, which results in incorrect behavior.

In the file HCICordioTransport.cpp, line 238, A change was made that results in the OPPOSITE of want is needed. As a result getDriver().terminate() is NOW called for the PORTENTA and NICLA_VISION and ARDUINO_GIGA, where it should NOT.

-#if !defined(ARDUINO_PORTENTA_H7_M4) && !defined(ARDUINO_PORTENTA_H7_M7) && !defined(ARDUINO_NICLA_VISION)
+#if defined(ARDUINO_PORTENTA_H7_M4) || defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_NICLA_VISION) || defined(ARDUINO_GIGA)
  CordioHCIHook::getDriver().terminate();
#endif

The change should be :

#if !defined(ARDUINO_PORTENTA_H7_M4) && !defined(ARDUINO_PORTENTA_H7_M7) && !defined(ARDUINO_NICLA_VISION) && !defined(ARDUINO_GIGA)
  CordioHCIHook::getDriver().terminate();
#endif

regards,
Paulvha

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 27, 2023
@per1234 per1234 added the conclusion: resolved Issue was resolved label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants