Skip to content

Commit 2f8aea5

Browse files
authored
Merge pull request #4 from hmueller01/cp_outputs
optimize output in isForcedCP()
2 parents a420d41 + 0ec285b commit 2f8aea5

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

src/ESP_WiFiManager_Lite.h

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,8 +1639,7 @@ class ESP_WiFiManager_Lite
16391639
bool isForcedCP()
16401640
{
16411641
uint32_t readForcedConfigPortalFlag;
1642-
1643-
ESP_WML_LOGDEBUG(F("Check if isForcedCP"));
1642+
bool retForcedConfigPortal = false;
16441643

16451644
File file = FileFS.open(CONFIG_PORTAL_FILENAME, "r");
16461645
ESP_WML_LOGINFO(F("LoadCPFile "));
@@ -1670,17 +1669,16 @@ class ESP_WiFiManager_Lite
16701669
if (readForcedConfigPortalFlag == FORCED_CONFIG_PORTAL_FLAG_DATA)
16711670
{
16721671
persForcedConfigPortal = false;
1673-
return true;
1672+
retForcedConfigPortal = true;
16741673
}
16751674
else if (readForcedConfigPortalFlag == FORCED_PERS_CONFIG_PORTAL_FLAG_DATA)
16761675
{
16771676
persForcedConfigPortal = true;
1678-
return true;
1679-
}
1680-
else
1681-
{
1682-
return false;
1677+
retForcedConfigPortal = true;
16831678
}
1679+
1680+
ESP_WML_LOGINFO1(F("Check if isForcedCP: "), retForcedConfigPortal ? F("true") : F("false"));
1681+
return retForcedConfigPortal;
16841682
}
16851683

16861684
//////////////////////////////////////////////
@@ -2149,29 +2147,25 @@ class ESP_WiFiManager_Lite
21492147
bool isForcedCP()
21502148
{
21512149
uint32_t readForcedConfigPortalFlag;
2150+
bool retForcedConfigPortal = false;
21522151

2153-
ESP_WML_LOGINFO(F("Check if isForcedCP"));
2154-
2155-
// Return true if forced CP (0xDEADBEEF read at offset EPROM_START + DRD_FLAG_DATA_SIZE + CONFIG_DATA_SIZE)
2156-
// => set flag noForcedConfigPortal = false
21572152
EEPROM.get(CONFIG_EEPROM_START + CONFIG_DATA_SIZE, readForcedConfigPortalFlag);
21582153

21592154
// Return true if forced CP (0xDEADBEEF read at offset EPROM_START + DRD_FLAG_DATA_SIZE + CONFIG_DATA_SIZE)
21602155
// => set flag noForcedConfigPortal = false
21612156
if (readForcedConfigPortalFlag == FORCED_CONFIG_PORTAL_FLAG_DATA)
21622157
{
21632158
persForcedConfigPortal = false;
2164-
return true;
2159+
retForcedConfigPortal = true;
21652160
}
21662161
else if (readForcedConfigPortalFlag == FORCED_PERS_CONFIG_PORTAL_FLAG_DATA)
21672162
{
21682163
persForcedConfigPortal = true;
2169-
return true;
2170-
}
2171-
else
2172-
{
2173-
return false;
2164+
retForcedConfigPortal = true;
21742165
}
2166+
2167+
ESP_WML_LOGINFO1(F("Check if isForcedCP: "), retForcedConfigPortal ? F("true") : F("false"));
2168+
return retForcedConfigPortal;
21752169
}
21762170

21772171
//////////////////////////////////////////////

0 commit comments

Comments
 (0)