apollo-tools: remove dependency on apollo-env (#2339)

As far as I can tell, the only use `@apollographql/apollo-tools` makes
of `apollo-env` is the ability to use `Array.flat` in pre-12 Node. Now,
we probably should just make this whole repo require Node 12 like we are
doing for Apollo Server 3. But a simpler way to break this dependency is
to just implement a single-level Array.flat ourselves. (The calls to
Array.flat do not take advantage of its ability to flatten more than one
level of nested array.)

This will allow us to stop installing polyfills in Apollo Server 3 (see
apollographql/apollo-server#2634).

Author: glasser

CHANGELOG.md

@@ -25,8 +25,12 @@
 - `vscode-apollo`
   - <First `vscode-apollo` related entry goes here>
 
+## [email protected]
+- Remove dependency on `apollo-env`, so using this package no longer installs polyfills.
+
 ## [email protected]
 - Complex directive arguments don't break `transformSchema` (Fixes #2162) [PR #2335](https://github.com/apollographql/apollo-tooling/pull/2335)
+
 ## [email protected]
 
 - Add a deprecation message to all `apollo service:*` commands, pointing people towards the [Apollo Rover CLI migration guide](https://go.apollo.dev/t/migration). <br/>

package-lock.json

@@ -15,9 +15,6 @@
     "node": ">=8",
     "npm": ">=6"
   },
-  "dependencies": {
-    "apollo-env": "file:../apollo-env"
-  },
   "jest": {
     "preset": "ts-jest",
     "testEnvironment": "node",
@@ -34,9 +31,6 @@
     "transformIgnorePatterns": [
       "/node_modules/"
     ],
-    "setupFiles": [
-      "apollo-env"
-    ],
     "snapshotSerializers": [
       "<rootDir>/src/__tests__/snapshotSerializers/astSerializer.ts",
       "<rootDir>/src/__tests__/snapshotSerializers/graphQLTypeSerializer.ts"

packages/apollo-tools/package.json

@@ -13,7 +13,8 @@ import {
   isObjectType,
   SchemaDefinitionNode,
   OperationTypeNode,
-  SchemaExtensionNode
+  SchemaExtensionNode,
+  OperationTypeDefinitionNode
 } from "graphql";
 import { isNode, isDocumentNode } from "./utilities/graphql";
 import { GraphQLResolverMap } from "./schema/resolverMap";
@@ -29,6 +30,10 @@ interface GraphQLServiceDefinition {
   errors?: GraphQLError[];
 }
 
+function flattened<T>(arr: ReadonlyArray<ReadonlyArray<T>>): ReadonlyArray<T> {
+  return new Array<T>().concat(...arr);
+}
+
 export function buildServiceDefinition(
   modules: GraphQLSchemaModule[]
 ): GraphQLServiceDefinition {
@@ -119,10 +124,11 @@ export function buildServiceDefinition(
     // but this matches the current 'last definition wins' behavior of `buildASTSchema`.
     const schemaDefinition = schemaDefinitions[schemaDefinitions.length - 1];
 
-    const operationTypes = [schemaDefinition, ...schemaExtensions]
-      .map(node => node.operationTypes)
-      .filter(isNotNullOrUndefined)
-      .flat();
+    const operationTypes = flattened(
+      [schemaDefinition, ...schemaExtensions]
+        .map(node => node.operationTypes)
+        .filter(isNotNullOrUndefined)
+    );
 
     for (const operationType of operationTypes) {
       const typeName = operationType.type.name.value;
@@ -178,15 +184,15 @@ export function buildServiceDefinition(
   }
 
   try {
-    const typeDefinitions = Object.values(typeDefinitionsMap).flat();
-    const directives = Object.values(directivesMap).flat();
+    const typeDefinitions = flattened(Object.values(typeDefinitionsMap));
+    const directives = flattened(Object.values(directivesMap));
 
     let schema = buildASTSchema({
       kind: Kind.DOCUMENT,
       definitions: [...typeDefinitions, ...directives]
     });
 
-    const typeExtensions = Object.values(typeExtensionsMap).flat();
+    const typeExtensions = flattened(Object.values(typeExtensionsMap));
 
     if (typeExtensions.length > 0) {
       schema = extendSchema(schema, {

packages/apollo-tools/src/buildServiceDefinition.ts

@@ -1,5 +1,3 @@
-import "apollo-env";
-
 export * from "./utilities";
 
 export * from "./schema";

packages/apollo-tools/src/index.ts

@@ -5,6 +5,5 @@
     "outDir": "./lib"
   },
   "include": ["./src/**/*"],
-  "exclude": ["**/__tests__/*", "**/__mocks__/*"],
-  "references": [{ "path": "../apollo-env" }]
+  "exclude": ["**/__tests__/*", "**/__mocks__/*"]
 }