You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SPARK-42335][SQL] Pass the comment option through to univocity if users set it explicitly in CSV dataSource
### What changes were proposed in this pull request?
Pass the comment option through to univocity if users set it explicitly in CSV dataSource.
### Why are the changes needed?
In #29516 , in order to fix some bugs, univocity-parsers was upgrade from 2.8.3 to 2.9.0, it also involved a new feature of univocity-parsers that quoting values of the first column that start with the comment character. It made a breaking for users downstream that handing a whole row as input.
Before this change:
#abc,1
After this change:
"#abc",1
We change the related `isCommentSet` check logic to enable users to keep behavior as before.
### Does this PR introduce _any_ user-facing change?
Yes, a little. If users set comment option as '\u0000' explicitly, now they should remove it to keep comment option unset.
### How was this patch tested?
Add a full new test.
Closes#39878 from wayneguow/comment.
Authored-by: wayneguow <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
0 commit comments