Skip to content

Commit ee5e81e

Browse files
authored
[SUREFIRE-2146] Don't draw border around reporting tables (#596)
1 parent 11d0541 commit ee5e81e

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ private void constructSummarySection( LocalizedProperties bundle, Sink sink )
130130

131131
sink.table();
132132

133-
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
133+
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );
134134

135135
sink.tableRow();
136136

@@ -196,7 +196,7 @@ private void constructPackagesSection( LocalizedProperties bundle, Sink sink,
196196

197197
sink.table();
198198

199-
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
199+
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );
200200

201201
sink.tableRow();
202202

@@ -281,7 +281,7 @@ private void constructPackagesSection( LocalizedProperties bundle, Sink sink,
281281
{
282282
sink.table();
283283

284-
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true );
284+
sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false );
285285

286286
sink.tableRow();
287287

@@ -412,7 +412,7 @@ private void constructTestCasesSection( LocalizedProperties bundle, Sink sink )
412412
{
413413
sink.table();
414414

415-
sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, true );
415+
sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, false );
416416

417417
for ( ReportTestCase testCase : testCases )
418418
{
@@ -555,7 +555,7 @@ private void constructFailureDetails( Sink sink, LocalizedProperties bundle, Lis
555555

556556
sink.table();
557557

558-
sink.tableRows( new int[]{ LEFT, LEFT }, true );
558+
sink.tableRows( new int[]{ LEFT, LEFT }, false );
559559

560560
for ( ReportTestCase tCase : failures )
561561
{

maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
5454
gen.doGenerateReport( new SurefireReportMojo().getBundle( ENGLISH ), sink );
5555
String xml = writer.toString();
5656
assertThat( xml, containsString( toSystemNewLine(
57-
"<table border=\"1\" class=\"bodyTable\">\n"
57+
"<table border=\"0\" class=\"bodyTable\">\n"
5858
+ "<tr class=\"a\">\n"
5959
+ "<th>Tests</th>\n"
6060
+ "<th>Errors</th>\n"
@@ -72,7 +72,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
7272
+ "</tr>"
7373
+ "</table>" ) ) );
7474
assertThat( xml, containsString( toSystemNewLine(
75-
"<table border=\"1\" class=\"bodyTable\">\n"
75+
"<table border=\"0\" class=\"bodyTable\">\n"
7676
+ "<tr class=\"a\">\n"
7777
+ "<th>Package</th>\n"
7878
+ "<th>Tests</th>\n"
@@ -90,7 +90,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
9090
+ "<td align=\"left\">0%</td>\n"
9191
+ "<td align=\"left\">0</td></tr></table>" ) ) );
9292
assertThat( xml, containsString( toSystemNewLine(
93-
"<table border=\"1\" class=\"bodyTable\">\n"
93+
"<table border=\"0\" class=\"bodyTable\">\n"
9494
+ "<tr class=\"a\">\n"
9595
+ "<th></th>\n"
9696
+ "<th>Class</th>\n"
@@ -110,7 +110,7 @@ public void testCorruptedTestCaseFailureWithMissingErrorTypeAndMessage()
110110
+ "<td align=\"left\">0%</td>\n"
111111
+ "<td align=\"left\">0</td></tr></table>" ) ) );
112112
assertThat( xml, containsString( toSystemNewLine(
113-
"<table border=\"1\" class=\"bodyTable\">\n"
113+
"<table border=\"0\" class=\"bodyTable\">\n"
114114
+ "<tr class=\"a\">\n"
115115
+ "<td align=\"left\"><figure><img src=\"images/icon_error_sml.gif\" alt=\"\" /></figure></td>\n"
116116
+ "<td align=\"left\"><a id=\"surefire.MyTest.test\"></a>test</td></tr>\n"

surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
/**
2929
* Inclusive test patters:<p>
3030
*
31-
* <table cellspacing=0 border=1>
31+
* <table cellspacing=0 border=0>
3232
* <tr>
3333
* <td style=min-width:50px> test</td>
3434
* <td style=min-width:50px></td>
@@ -178,7 +178,7 @@
178178
* <p>
179179
* Exclusive test patters:<p>
180180
*
181-
* <table cellspacing=0 border=1>
181+
* <table cellspacing=0 border=0>
182182
* <tr>
183183
* <td style=min-width:50px> test</td>
184184
* <td style=min-width:50px></td>

0 commit comments

Comments
 (0)