Skip to content

Commit ade2e35

Browse files
authored
[MSHADE-428] Prevent null value in array of transformers (#229)
As Plexus will silently add it as explain it in issue. This fix merely improves user experience, but not throwing cryptic or totally misleading errors. --- https://issues.apache.org/jira/browse/MSHADE-428
1 parent b573b8c commit ade2e35

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -915,11 +915,16 @@ private List<Relocator> getRelocators() {
915915
return relocators;
916916
}
917917

918-
private List<ResourceTransformer> getResourceTransformers() {
918+
private List<ResourceTransformer> getResourceTransformers() throws MojoExecutionException {
919919
if (transformers == null) {
920920
return Collections.emptyList();
921921
}
922-
922+
for (ResourceTransformer transformer : transformers) {
923+
if (transformer == null) {
924+
throw new MojoExecutionException(
925+
"Failed to create shaded artifact: parameter transformers contains null (double-check XML attribute)");
926+
}
927+
}
923928
return Arrays.asList(transformers);
924929
}
925930

0 commit comments

Comments
 (0)