Skip to content

Commit d60bbc3

Browse files
authored
Prefer more modern try with resources over IOUtil.close (#179)
1 parent 3e077e7 commit d60bbc3

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RemoveReleasePomsPhaseTest.java

+2-13
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import org.apache.maven.shared.release.config.ReleaseUtils;
4141
import org.apache.maven.shared.release.env.DefaultReleaseEnvironment;
4242
import org.apache.maven.shared.release.util.ReleaseUtil;
43-
import org.codehaus.plexus.util.IOUtil;
4443
import org.junit.Test;
4544

4645
import static org.junit.Assert.assertEquals;
@@ -162,14 +161,9 @@ public void testExecuteWithSuppressCommitBeforeTag() throws Exception {
162161
ReleaseResult result = phase.execute(
163162
ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
164163

165-
BufferedReader reader = null;
166-
try {
167-
reader = new BufferedReader(new StringReader(result.getOutput()));
168-
164+
try (BufferedReader reader = new BufferedReader(new StringReader(result.getOutput()))) {
169165
assertEquals("[INFO] Removing release POM for 'artifactId'...", reader.readLine());
170166
assertEquals("Expected EOF", null, reader.readLine());
171-
} finally {
172-
IOUtil.close(reader);
173167
}
174168

175169
// never invoke scmProviderMock
@@ -193,18 +187,13 @@ public void testSimulateWithSuppressCommitBeforeTag() throws Exception {
193187
ReleaseResult result = phase.simulate(
194188
ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
195189

196-
BufferedReader reader = null;
197-
try {
198-
reader = new BufferedReader(new StringReader(result.getOutput()));
199-
190+
try (BufferedReader reader = new BufferedReader(new StringReader(result.getOutput()))) {
200191
assertEquals("[INFO] Removing release POM for 'artifactId'...", reader.readLine());
201192
assertEquals(
202193
"[INFO] Full run would be removing ["
203194
+ reactorProjects.get(0).getFile().getParent() + File.separator + "release-pom.xml]",
204195
reader.readLine());
205196
assertEquals("Expected EOF", null, reader.readLine());
206-
} finally {
207-
IOUtil.close(reader);
208197
}
209198

210199
// never invoke scmProviderMock

0 commit comments

Comments
 (0)