Skip to content

Commit b99f3c1

Browse files
committed
[MINVOKER-315] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
This closes #155
1 parent bf51507 commit b99f3c1

File tree

2 files changed

+37
-38
lines changed

2 files changed

+37
-38
lines changed

pom.xml

+31-1
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,23 @@ under the License.
143143
<version>${mavenVersion}</version>
144144
<scope>provided</scope>
145145
</dependency>
146+
<dependency>
147+
<groupId>org.apache.maven</groupId>
148+
<artifactId>maven-settings-builder</artifactId>
149+
<version>${mavenVersion}</version>
150+
<scope>provided</scope>
151+
</dependency>
146152

153+
<!-- shared -->
154+
<dependency>
155+
<groupId>org.apache.maven.reporting</groupId>
156+
<artifactId>maven-reporting-api</artifactId>
157+
<version>3.1.1</version>
158+
</dependency>
147159
<dependency>
148160
<groupId>org.apache.maven.reporting</groupId>
149161
<artifactId>maven-reporting-impl</artifactId>
150-
<version>3.1.0</version>
162+
<version>3.2.0</version>
151163
<exclusions>
152164
<exclusion>
153165
<groupId>org.codehaus.plexus</groupId>
@@ -156,6 +168,13 @@ under the License.
156168
</exclusions>
157169
</dependency>
158170

171+
<!-- doxia -->
172+
<dependency>
173+
<groupId>org.apache.maven.doxia</groupId>
174+
<artifactId>doxia-sink-api</artifactId>
175+
<version>1.11.1</version>
176+
</dependency>
177+
159178
<dependency>
160179
<groupId>org.apache.maven.plugin-tools</groupId>
161180
<artifactId>maven-plugin-annotations</artifactId>
@@ -213,6 +232,17 @@ under the License.
213232
<artifactId>plexus-interpolation</artifactId>
214233
<version>1.26</version>
215234
</dependency>
235+
<dependency>
236+
<groupId>org.codehaus.plexus</groupId>
237+
<artifactId>plexus-i18n</artifactId>
238+
<version>1.0-beta-10</version>
239+
<exclusions>
240+
<exclusion>
241+
<groupId>org.codehaus.plexus</groupId>
242+
<artifactId>plexus-component-api</artifactId>
243+
</exclusion>
244+
</exclusions>
245+
</dependency>
216246
<dependency>
217247
<groupId>org.apache.maven.shared</groupId>
218248
<artifactId>maven-shared-utils</artifactId>

src/main/java/org/apache/maven/plugins/invoker/InvokerReport.java

+6-37
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,11 @@
3030
import java.util.Locale;
3131

3232
import org.apache.maven.doxia.sink.Sink;
33-
import org.apache.maven.doxia.siterenderer.Renderer;
3433
import org.apache.maven.plugins.invoker.model.BuildJob;
3534
import org.apache.maven.plugins.invoker.model.io.xpp3.BuildJobXpp3Reader;
3635
import org.apache.maven.plugins.annotations.Component;
3736
import org.apache.maven.plugins.annotations.Mojo;
3837
import org.apache.maven.plugins.annotations.Parameter;
39-
import org.apache.maven.project.MavenProject;
4038
import org.apache.maven.reporting.AbstractMavenReport;
4139
import org.apache.maven.reporting.MavenReportException;
4240
import org.codehaus.plexus.i18n.I18N;
@@ -58,32 +56,12 @@ public class InvokerReport
5856
extends AbstractMavenReport
5957
{
6058

61-
/**
62-
* The Maven Project.
63-
*/
64-
@Parameter( defaultValue = "${project}", readonly = true, required = true )
65-
protected MavenProject project;
66-
67-
/**
68-
* Doxia Site Renderer component.
69-
*/
70-
@Component
71-
protected Renderer siteRenderer;
72-
7359
/**
7460
* Internationalization component.
7561
*/
7662
@Component
7763
protected I18N i18n;
7864

79-
/**
80-
* The output directory for the report. Note that this parameter is only evaluated if the goal is run directly from
81-
* the command line. If the goal is run indirectly as part of a site generation, the output directory configured in
82-
* the Maven Site Plugin is used instead.
83-
*/
84-
@Parameter( defaultValue = "${project.reporting.outputDirectory}", required = true )
85-
protected File outputDirectory;
86-
8765
/**
8866
* Base directory where all build reports have been written to.
8967
*/
@@ -185,6 +163,7 @@ protected void executeReport( Locale locale )
185163

186164
// detail tests table header
187165
sink.table();
166+
sink.tableRows( null, false );
188167

189168
sink.tableRow();
190169
// -------------------------------------------
@@ -202,6 +181,7 @@ protected void executeReport( Locale locale )
202181
renderBuildJob( buildJob );
203182
}
204183

184+
sink.tableRows_();
205185
sink.table_();
206186

207187
sink.body_();
@@ -228,6 +208,8 @@ private void constructSummarySection( List<? extends BuildJob> buildJobs, Locale
228208
// ------------------------------------------------------------------------
229209

230210
sink.table();
211+
sink.tableRows( null, false );
212+
231213
sink.tableRow();
232214

233215
sinkTableHeader( sink, getText( locale, "report.invoker.summary.number" ) );
@@ -283,6 +265,8 @@ else if ( BuildJob.Result.SKIPPED.equals( buildJob.getResult() ) )
283265
sinkCell( sink, secondsFormat.format( totalTime / number ) );
284266

285267
sink.tableRow_();
268+
269+
sink.tableRows_();
286270
sink.table_();
287271

288272
}
@@ -337,21 +321,6 @@ private String getFormattedName( String name, String description )
337321
return nameAndDescriptionFormat.format( new Object[] { name, description } );
338322
}
339323

340-
protected String getOutputDirectory()
341-
{
342-
return outputDirectory.getAbsolutePath();
343-
}
344-
345-
protected MavenProject getProject()
346-
{
347-
return project;
348-
}
349-
350-
protected Renderer getSiteRenderer()
351-
{
352-
return siteRenderer;
353-
}
354-
355324
public String getDescription( Locale locale )
356325
{
357326
return getText( locale, "report.invoker.result.description" );

0 commit comments

Comments
 (0)