Skip to content

Commit 90281bc

Browse files
committed
[MARTIFACT-44] improve documentation
1 parent 69db93e commit 90281bc

File tree

9 files changed

+13
-9
lines changed

9 files changed

+13
-9
lines changed

src/it/flatten/invoker.properties renamed to src/it/compare-flatten/invoker.properties

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,7 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18+
# initial reference build: install
1819
invoker.goals.1=clean install
19-
invoker.goals.2=clean package artifact:compare
20+
# second build: verify (could be package, but not install to avoid overriding reference)
21+
invoker.goals.2=clean verify artifact:compare
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/it/compare-mono/invoker.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18+
# initial reference build: install
1819
invoker.goals.1=clean install
20+
# second build: package (could be verify, but not install to avoid overriding reference)
1921
invoker.goals.2=clean package artifact:compare
2022
invoker.buildResult.2=failure

src/main/java/org/apache/maven/plugins/artifact/buildinfo/BuildinfoMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.apache.maven.project.MavenProjectHelper;
3030

3131
/**
32-
* Creates a buildinfo file recording build environment and output, as specified in
32+
* Creates a buildinfo file recording build environment and output (from {@code package}), as specified in
3333
* <a href="https://reproducible-builds.org/docs/jvm/">Reproducible Builds for the JVM</a>
3434
* for mono-module build, and extended for multi-module build.
3535
*/

src/main/java/org/apache/maven/plugins/artifact/buildinfo/CompareMojo.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
import org.eclipse.aether.repository.RemoteRepository;
4747

4848
/**
49-
* Compare current build output with reference either previously installed or downloaded from a remote repository:
50-
* results go to {@code .buildcompare} file.
49+
* Compare current build output (from {@code package}) against reference either previously {@code install}-ed or downloaded from a remote
50+
* repository: comparison results go to {@code .buildcompare} file.
5151
*
5252
* @since 3.2.0
5353
*/
@@ -68,7 +68,7 @@ public class CompareMojo extends AbstractBuildinfoMojo {
6868
private String referenceRepo;
6969

7070
/**
71-
* Compare aggregate only (ie wait for the last module) or do buildcompare on each module.
71+
* Compare aggregate only (ie wait for the last module) or also compare on each module.
7272
* @since 3.2.0
7373
*/
7474
@Parameter(property = "compare.aggregate.only", defaultValue = "false")
@@ -124,7 +124,7 @@ protected void skip(MavenProject last) throws MojoExecutionException {
124124
/**
125125
* Check current build result with reference.
126126
*
127-
* @artifacts a Map of artifacts added to the build info with their associated property key prefix
127+
* @param artifacts a Map of artifacts added to the build info with their associated property key prefix
128128
* (<code>outputs.[#module.].#artifact</code>)
129129
* @throws MojoExecutionException
130130
*/

src/site/apt/index.apt.vm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ ${project.name}
3232

3333
* Goals Overview
3434

35-
The Artifact Plugin only has 3 goals currently:
35+
The Artifact Plugin has 3 goals currently:
3636

37-
* {{{./buildinfo-mojo.html}artifact:buildinfo}} records current build results in {{{https://reproducible-builds.org/docs/jvm/}Reproducible Builds buildinfo}} file,
37+
* {{{./buildinfo-mojo.html}artifact:buildinfo}} records current build results (from <<<package>>>) in {{{https://reproducible-builds.org/docs/jvm/}Reproducible Builds buildinfo}} file,
3838

39-
* {{{./compare-mojo.html}artifact:compare}} compares current build output against reference build previously published,
39+
* {{{./compare-mojo.html}artifact:compare}} compares current build output (from <<<package>>>) against reference build previously published,
4040

4141
* {{{./check-buildplan-mojo.html}artifact:check-buildplan}} checks the project's buildplan to find if any used {{{./plugin-issues.html}plugin has a known Reproducible Builds issue}}.
4242

0 commit comments

Comments
 (0)