From f403cea6288b5c82665ed40f0416eba8bea7e77e Mon Sep 17 00:00:00 2001
From: Jiseok CHOI <jiseok.dev@gmail.com>
Date: Sat, 6 Aug 2022 17:20:37 +0900
Subject: [PATCH 1/2] Remove unnecessary `Box`

---
 src/ast/mod.rs              |  2 +-
 src/ast/query.rs            |  2 +-
 src/parser.rs               |  6 +++---
 src/test_utils.rs           |  2 +-
 tests/sqlparser_mysql.rs    | 12 ++++++------
 tests/sqlparser_postgres.rs |  4 ++--
 6 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/ast/mod.rs b/src/ast/mod.rs
index 312a86813..629c79489 100644
--- a/src/ast/mod.rs
+++ b/src/ast/mod.rs
@@ -783,7 +783,7 @@ pub enum Statement {
         partition_action: Option<AddDropSync>,
     },
     /// SELECT
-    Query(Box<Query>),
+    Query(Query),
     /// INSERT
     Insert {
         /// Only for Sqlite
diff --git a/src/ast/query.rs b/src/ast/query.rs
index bc5af9e5f..57fdd04a9 100644
--- a/src/ast/query.rs
+++ b/src/ast/query.rs
@@ -74,7 +74,7 @@ pub enum SetExpr {
     Select(Box<Select>),
     /// Parenthesized SELECT subquery, which may include more set operations
     /// in its body and an optional ORDER BY / LIMIT.
-    Query(Box<Query>),
+    Query(Query),
     /// UNION/EXCEPT/INTERSECT of two queries
     SetOperation {
         op: SetOperator,
diff --git a/src/parser.rs b/src/parser.rs
index 76190feb9..5536838fb 100644
--- a/src/parser.rs
+++ b/src/parser.rs
@@ -160,7 +160,7 @@ impl<'a> Parser<'a> {
                 Keyword::ANALYZE => Ok(self.parse_analyze()?),
                 Keyword::SELECT | Keyword::WITH | Keyword::VALUES => {
                     self.prev_token();
-                    Ok(Statement::Query(Box::new(self.parse_query()?)))
+                    Ok(Statement::Query(self.parse_query()?))
                 }
                 Keyword::TRUNCATE => Ok(self.parse_truncate()?),
                 Keyword::MSCK => Ok(self.parse_msck()?),
@@ -205,7 +205,7 @@ impl<'a> Parser<'a> {
             },
             Token::LParen => {
                 self.prev_token();
-                Ok(Statement::Query(Box::new(self.parse_query()?)))
+                Ok(Statement::Query(self.parse_query()?))
             }
             unexpected => self.expected("an SQL statement", unexpected),
         }
@@ -3429,7 +3429,7 @@ impl<'a> Parser<'a> {
             // CTEs are not allowed here, but the parser currently accepts them
             let subquery = self.parse_query()?;
             self.expect_token(&Token::RParen)?;
-            SetExpr::Query(Box::new(subquery))
+            SetExpr::Query(subquery)
         } else if self.parse_keyword(Keyword::VALUES) {
             SetExpr::Values(self.parse_values()?)
         } else {
diff --git a/src/test_utils.rs b/src/test_utils.rs
index c5ea62085..f6ae9b3b5 100644
--- a/src/test_utils.rs
+++ b/src/test_utils.rs
@@ -107,7 +107,7 @@ impl TestedDialects {
     /// after a serialization round-trip.
     pub fn verified_query(&self, sql: &str) -> Query {
         match self.verified_stmt(sql) {
-            Statement::Query(query) => *query,
+            Statement::Query(query) => query,
             _ => panic!("Expected Query"),
         }
     }
diff --git a/tests/sqlparser_mysql.rs b/tests/sqlparser_mysql.rs
index b3c02de30..0eacdffa2 100644
--- a/tests/sqlparser_mysql.rs
+++ b/tests/sqlparser_mysql.rs
@@ -312,7 +312,7 @@ fn parse_quote_identifiers_2() {
     let sql = "SELECT `quoted `` identifier`";
     assert_eq!(
         mysql().verified_stmt(sql),
-        Statement::Query(Box::new(Query {
+        Statement::Query(Query {
             with: None,
             body: Box::new(SetExpr::Select(Box::new(Select {
                 distinct: false,
@@ -337,7 +337,7 @@ fn parse_quote_identifiers_2() {
             offset: None,
             fetch: None,
             lock: None,
-        }))
+        })
     );
 }
 
@@ -346,7 +346,7 @@ fn parse_quote_identifiers_3() {
     let sql = "SELECT ```quoted identifier```";
     assert_eq!(
         mysql().verified_stmt(sql),
-        Statement::Query(Box::new(Query {
+        Statement::Query(Query {
             with: None,
             body: Box::new(SetExpr::Select(Box::new(Select {
                 distinct: false,
@@ -371,7 +371,7 @@ fn parse_quote_identifiers_3() {
             offset: None,
             fetch: None,
             lock: None,
-        }))
+        })
     );
 }
 
@@ -766,7 +766,7 @@ fn parse_substring_in_select() {
     ) {
         Statement::Query(query) => {
             assert_eq!(
-                Box::new(Query {
+                Query {
                     with: None,
                     body: Box::new(SetExpr::Select(Box::new(Select {
                         distinct: true,
@@ -812,7 +812,7 @@ fn parse_substring_in_select() {
                     offset: None,
                     fetch: None,
                     lock: None,
-                }),
+                },
                 query
             );
         }
diff --git a/tests/sqlparser_postgres.rs b/tests/sqlparser_postgres.rs
index 632a8bf34..5c442324e 100644
--- a/tests/sqlparser_postgres.rs
+++ b/tests/sqlparser_postgres.rs
@@ -1068,9 +1068,9 @@ fn parse_prepare() {
     };
     assert_eq!(
         sub_stmt,
-        Box::new(Statement::Query(Box::new(pg_and_generic().verified_query(
+        Box::new(Statement::Query(pg_and_generic().verified_query(
             "SELECT * FROM customers WHERE customers.id = a1"
-        ))))
+        )))
     );
 }
 

From a8f33371c87bac1724c570a093d545bba0810916 Mon Sep 17 00:00:00 2001
From: Jiseok CHOI <jiseok.dev@gmail.com>
Date: Sat, 6 Aug 2022 17:33:21 +0900
Subject: [PATCH 2/2] Add missing doc-comment to `Query` variant of `Statement`
 enum

---
 src/ast/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ast/mod.rs b/src/ast/mod.rs
index 629c79489..f0d59c544 100644
--- a/src/ast/mod.rs
+++ b/src/ast/mod.rs
@@ -782,7 +782,7 @@ pub enum Statement {
         repair: bool,
         partition_action: Option<AddDropSync>,
     },
-    /// SELECT
+    /// SELECT, VALUES
     Query(Query),
     /// INSERT
     Insert {