From 9e384fad06fc2e5c78f121ae48f07b5d1d44544a Mon Sep 17 00:00:00 2001 From: ifeanyi Date: Fri, 25 Apr 2025 08:17:34 +0200 Subject: [PATCH] Handle missing login in changelog generate script Noticed during #1822 that the script initially failed due to [this commit](https://github.com/apache/datafusion-sqlparser-rs/commit/10cf7c164ee0bae8a71e1d8f0af5851b96465692) no longer having the associated GitHub user. Updates the script to skip the username referencing in such cases. --- dev/release/generate-changelog.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dev/release/generate-changelog.py b/dev/release/generate-changelog.py index 52fd2e548..6f2b7c41c 100755 --- a/dev/release/generate-changelog.py +++ b/dev/release/generate-changelog.py @@ -28,7 +28,8 @@ def print_pulls(repo_name, title, pulls): print() for (pull, commit) in pulls: url = "https://github.com/{}/pull/{}".format(repo_name, pull.number) - print("- {} [#{}]({}) ({})".format(pull.title, pull.number, url, commit.author.login)) + author = f"({commit.author.login})" if commit.author else '' + print("- {} [#{}]({}) {}".format(pull.title, pull.number, url, author)) print() @@ -161,4 +162,4 @@ def cli(args=None): generate_changelog(repo, project, args.tag1, args.tag2, args.version) if __name__ == "__main__": - cli() \ No newline at end of file + cli()