-
Notifications
You must be signed in to change notification settings - Fork 601
Add serde
support to AST structs and enums
#183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree. I actually add this by hand to my local copy every now and then using two global replacements:
...but if I'm not alone, it's probably a good idea to include it in the crate, via an optional feature, as you suggest. |
@nickolay Thanks, it's so good to see that I'm not the only one who needs I'm currently migrating a parser of my existing sql db project from And... because I should use Hope to get positive feedback from others. |
Serde support could be quite useful. I agree as an optional feature would be the best, to avoid longer compile times. |
Due to https://github.com/andygrove/sqlparser-rs/pull/189 |
That's just an instance of adding this by hand to my local copy, not intended to be merged (it's not optional, for one). Please feel free to PR your branch. |
Ok, then I'll make PR, thanks :) |
Hello, I found that
serde
is not applied in this project, so there's no easy way to serialize/deserialize AST nodes.serde
is often quite useful for some cases; considering to parse query and store the result in somewhere, or parsing remotely and send to database over network... etc.It looks good to add
serde
as optional likebigdecimal
.then something similar with this below will be added.
And for every
ast/
codes,How do you think of this? If it is ok, then I'd like to work on this issue.
The text was updated successfully, but these errors were encountered: