ensure tests are testing the right things

Author: maxcountryman

tests/sqlparser_common.rs

@@ -567,19 +567,16 @@ fn parse_not_precedence() {
     );
 
     // NOT has lower precedence than LIKE, so the following parses as NOT ('a' NOT LIKE 'b')
-    let sql = "CAST('a' AS NOT) NOT LIKE 'b'";
+    let sql = "NOT 'a' NOT LIKE 'b'";
     assert_eq!(
         verified_expr(sql),
-        Expr::BinaryOp {
-            left: Box::new(Expr::Cast {
-                expr: Box::new(Expr::Value(Value::SingleQuotedString("a".into()))),
-                data_type: DataType::Custom(ObjectName(vec![Ident {
-                    value: "NOT".into(),
-                    quote_style: None
-                }]))
+        Expr::UnaryOp {
+            op: UnaryOperator::Not,
+            expr: Box::new(Expr::BinaryOp {
+                left: Box::new(Expr::Value(Value::SingleQuotedString("a".into()))),
+                op: BinaryOperator::NotLike,
+                right: Box::new(Expr::Value(Value::SingleQuotedString("b".into()))),
             }),
-            op: BinaryOperator::NotLike,
-            right: Box::new(Expr::Value(Value::SingleQuotedString("b".into())))
         },
     );
 
@@ -1439,40 +1436,38 @@ fn parse_literal_string() {
 
 #[test]
 fn parse_literal_date() {
-    let sql = "SELECT CAST('1999-01-01' AS date)";
+    let sql = "SELECT date '1999-01-01'";
     let select = verified_only_select(sql);
     assert_eq!(
-        &Expr::Cast {
-            expr: Box::new(Expr::Value(Value::SingleQuotedString("1999-01-01".into()))),
-            data_type: DataType::Date
+        &Expr::TypedString {
+            data_type: DataType::Date,
+            value: "1999-01-01".into()
         },
         expr_from_projection(only(&select.projection)),
     );
 }
 
 #[test]
 fn parse_literal_time() {
-    let sql = "SELECT CAST('01:23:34' AS time)";
+    let sql = "SELECT time '01:23:34'";
     let select = verified_only_select(sql);
     assert_eq!(
-        &Expr::Cast {
-            expr: Box::new(Expr::Value(Value::SingleQuotedString("01:23:34".into()))),
-            data_type: DataType::Time
+        &Expr::TypedString {
+            data_type: DataType::Time,
+            value: "01:23:34".into()
         },
         expr_from_projection(only(&select.projection)),
     );
 }
 
 #[test]
 fn parse_literal_timestamp() {
-    let sql = "SELECT CAST('1999-01-01 01:23:34' AS timestamp)";
+    let sql = "SELECT timestamp '1999-01-01 01:23:34'";
     let select = verified_only_select(sql);
     assert_eq!(
-        &Expr::Cast {
-            expr: Box::new(Expr::Value(Value::SingleQuotedString(
-                "1999-01-01 01:23:34".into()
-            ))),
-            data_type: DataType::Timestamp
+        &Expr::TypedString {
+            data_type: DataType::Timestamp,
+            value: "1999-01-01 01:23:34".into()
         },
         expr_from_projection(only(&select.projection)),
     );

tests/sqlparser_mssql.rs

@@ -41,8 +41,7 @@ fn parse_mssql_identifiers() {
 
 #[test]
 fn parse_mssql_single_quoted_aliases() {
-    let _ = ms_and_generic()
-        .one_statement_parses_to("SELECT foo 'alias'", "SELECT CAST('alias' AS foo)");
+    let _ = ms_and_generic().one_statement_parses_to("SELECT foo 'alias'", "SELECT foo AS 'alias'");
 }
 
 #[test]