fix some lints and tests, add purge on tables ad proper formatting for INSERT INTO TABLE

Author: hntd187

src/ast/mod.rs

@@ -461,6 +461,8 @@ pub enum Statement {
         source: Box<Query>,
         /// partitioned insert (Hive)
         partitioned: Option<Vec<Expr>>,
+        /// whether the insert has the table keyword (Hive)
+        table: bool,
     },
     Copy {
         /// TABLE
@@ -547,6 +549,9 @@ pub enum Statement {
         /// Whether `CASCADE` was specified. This will be `false` when
         /// `RESTRICT` or no drop behavior at all was specified.
         cascade: bool,
+        /// Hive allows you specify whether the table's stored data will be
+        /// deleted along with the dropped table
+        purge: bool,
     },
     /// SET <variable>
     ///
@@ -680,16 +685,14 @@ impl fmt::Display for Statement {
                 partitioned,
                 columns,
                 source,
+                table,
             } => {
                 write!(
                     f,
-                    "INSERT {act} {table_name} ",
+                    "INSERT {act}{tbl} {table_name} ",
                     table_name = table_name,
-                    act = if *overwrite {
-                        "OVERWRITE TABLE"
-                    } else {
-                        "INTO"
-                    }
+                    act = if *overwrite { "OVERWRITE" } else { "INTO" },
+                    tbl = if *table { " TABLE" } else { "" }
                 )?;
                 if !columns.is_empty() {
                     write!(f, "({}) ", display_comma_separated(columns))?;
@@ -975,13 +978,15 @@ impl fmt::Display for Statement {
                 if_exists,
                 names,
                 cascade,
+                purge,
             } => write!(
                 f,
-                "DROP {}{} {}{}",
+                "DROP {}{} {}{}{}",
                 object_type,
                 if *if_exists { " IF EXISTS" } else { "" },
                 display_comma_separated(names),
                 if *cascade { " CASCADE" } else { "" },
+                if *purge { " PURGE" } else { "" }
             ),
             Statement::SetVariable {
                 local,

src/ast/query.rs

@@ -57,6 +57,7 @@ impl fmt::Display for Query {
 
 /// A node in a tree, representing a "query body" expression, roughly:
 /// `SELECT ... [ {UNION|EXCEPT|INTERSECT} SELECT ...]`
+#[allow(clippy::large_enum_variant)]
 #[derive(Debug, Clone, PartialEq, Eq, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 pub enum SetExpr {

src/dialect/keywords.rs

@@ -336,6 +336,7 @@ define_keywords!(
     PREPARE,
     PRIMARY,
     PROCEDURE,
+    PURGE,
     RANGE,
     RANK,
     RCFILE,

src/parser.rs

@@ -1250,6 +1250,7 @@ impl Parser {
         let names = self.parse_comma_separated(Parser::parse_object_name)?;
         let cascade = self.parse_keyword(Keyword::CASCADE);
         let restrict = self.parse_keyword(Keyword::RESTRICT);
+        let purge = self.parse_keyword(Keyword::PURGE);
         if cascade && restrict {
             return parser_err!("Cannot specify both CASCADE and RESTRICT in DROP");
         }
@@ -1258,6 +1259,7 @@ impl Parser {
             if_exists,
             names,
             cascade,
+            purge,
         })
     }
 
@@ -2135,11 +2137,11 @@ impl Parser {
                 });
             }
         } else if variable.value == "TRANSACTION" && modifier.is_none() {
-            return Ok(Statement::SetTransaction {
+            Ok(Statement::SetTransaction {
                 modes: self.parse_transaction_modes()?,
-            });
+            })
         } else {
-            return self.expected("equals sign or TO", self.peek_token());
+            self.expected("equals sign or TO", self.peek_token())
         }
     }
 
@@ -2375,13 +2377,9 @@ impl Parser {
     /// Parse an INSERT statement
     pub fn parse_insert(&mut self) -> Result<Statement, ParserError> {
         let action = self.expect_one_of_keywords(&[Keyword::INTO, Keyword::OVERWRITE])?;
-        let overwrite = if action == Keyword::OVERWRITE {
-            true
-        } else {
-            false
-        };
+        let overwrite = action == Keyword::OVERWRITE;
         // Hive lets you put table here regardless
-        self.parse_keyword(Keyword::TABLE);
+        let table = self.parse_keyword(Keyword::TABLE);
         let table_name = self.parse_object_name()?;
         let columns = self.parse_parenthesized_column_list(Optional)?;
 
@@ -2400,6 +2398,7 @@ impl Parser {
             partitioned,
             columns,
             source,
+            table,
         })
     }
 

tests/sqlparser_common.rs

@@ -2715,6 +2715,7 @@ fn parse_drop_table() {
             if_exists,
             names,
             cascade,
+            purge: _,
         } => {
             assert_eq!(false, if_exists);
             assert_eq!(ObjectType::Table, object_type);
@@ -2734,6 +2735,7 @@ fn parse_drop_table() {
             if_exists,
             names,
             cascade,
+            purge: _,
         } => {
             assert_eq!(true, if_exists);
             assert_eq!(ObjectType::Table, object_type);

tests/sqlparser_hive.rs

@@ -69,6 +69,12 @@ fn parse_with_cte() {
     hive().verified_stmt(with);
 }
 
+#[test]
+fn drop_table_purge() {
+    let purge = "DROP TABLE db.table_name PURGE";
+    hive().verified_stmt(purge);
+}
+
 fn hive() -> TestedDialects {
     TestedDialects {
         dialects: vec![Box::new(HiveDialect {})],