Support group by cube/rollup etc in BigQuery (#1720)

Groennbeck · web-flow · commit 3e94877f03c5 · 2025-02-11T16:22:50.000+01:00
diff --git a/src/dialect/bigquery.rs b/src/dialect/bigquery.rs
@@ -115,6 +115,11 @@ impl Dialect for BigQueryDialect {
         true
     }
 
+    // See <https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#group_by_clause>
+    fn supports_group_by_expr(&self) -> bool {
+        true
+    }
+
     fn is_column_alias(&self, kw: &Keyword, _parser: &mut Parser) -> bool {
         !RESERVED_FOR_COLUMN_ALIAS.contains(kw)
     }

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,11 @@ impl Dialect for BigQueryDialect {`
`115`	`115`	`true`
`116`	`116`	`}`
`117`	`117`
	`118`	`+ // See <https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#group_by_clause>`
	`119`	`+ fn supports_group_by_expr(&self) -> bool {`
	`120`	`+ true`
	`121`	`+ }`
	`122`	`+`
`118`	`123`	`fn is_column_alias(&self, kw: &Keyword, _parser: &mut Parser) -> bool {`
`119`	`124`	`!RESERVED_FOR_COLUMN_ALIAS.contains(kw)`
`120`	`125`	`}`